Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable widening for nameless function expressions and arrow functions #20976

Closed
wants to merge 4 commits into from
Closed

Disable widening for nameless function expressions and arrow functions #20976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
804b812
Disable widening for nameless function expressions and arrow functions
weswigham Jan 2, 2018
c38f3a2
Troublesome test case
weswigham Jan 11, 2018
27b0c39
Only disable widening when the expression is contextually typed
weswigham Jan 11, 2018
560ccdc
Omit binding patterns from contextual type calculation for signature …
weswigham Jan 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 47 additions & 47 deletions src/compiler/checker.ts
View file
Open in desktop

Large diffs are not rendered by default.

17 changes: 17 additions & 0 deletions tests/baselines/reference/arrowFunctionMakesStrictLiteralCheck.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
tests/cases/compiler/arrowFunctionMakesStrictLiteralCheck.ts(6,17): error TS2322: Type '() => { x: number; y: number; }' is not assignable to type 'XGetter'.
Type '{ x: number; y: number; }' is not assignable to type 'X'.
Object literal may only specify known properties, and 'y' does not exist in type 'X'.


==== tests/cases/compiler/arrowFunctionMakesStrictLiteralCheck.ts (1 errors) ====
interface X { x: number; }

type XGetter = () => X;

const getX2: XGetter = () => {
return { x: 1, y: 2 }; // Expect excess property error on `y`
~~~~
!!! error TS2322: Type '() => { x: number; y: number; }' is not assignable to type 'XGetter'.
!!! error TS2322: Type '{ x: number; y: number; }' is not assignable to type 'X'.
!!! error TS2322: Object literal may only specify known properties, and 'y' does not exist in type 'X'.
}
13 changes: 13 additions & 0 deletions tests/baselines/reference/arrowFunctionMakesStrictLiteralCheck.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//// [arrowFunctionMakesStrictLiteralCheck.ts]
interface X { x: number; }

type XGetter = () => X;

const getX2: XGetter = () => {
return { x: 1, y: 2 }; // Expect excess property error on `y`
}

//// [arrowFunctionMakesStrictLiteralCheck.js]
var getX2 = function () {
return { x: 1, y: 2 }; // Expect excess property error on `y`
};
17 changes: 17 additions & 0 deletions tests/baselines/reference/arrowFunctionMakesStrictLiteralCheck.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
=== tests/cases/compiler/arrowFunctionMakesStrictLiteralCheck.ts ===
interface X { x: number; }
>X : Symbol(X, Decl(arrowFunctionMakesStrictLiteralCheck.ts, 0, 0))
>x : Symbol(X.x, Decl(arrowFunctionMakesStrictLiteralCheck.ts, 0, 13))

type XGetter = () => X;
>XGetter : Symbol(XGetter, Decl(arrowFunctionMakesStrictLiteralCheck.ts, 0, 26))
>X : Symbol(X, Decl(arrowFunctionMakesStrictLiteralCheck.ts, 0, 0))

const getX2: XGetter = () => {
>getX2 : Symbol(getX2, Decl(arrowFunctionMakesStrictLiteralCheck.ts, 4, 5))
>XGetter : Symbol(XGetter, Decl(arrowFunctionMakesStrictLiteralCheck.ts, 0, 26))

return { x: 1, y: 2 }; // Expect excess property error on `y`
>x : Symbol(x, Decl(arrowFunctionMakesStrictLiteralCheck.ts, 5, 9))
>y : Symbol(y, Decl(arrowFunctionMakesStrictLiteralCheck.ts, 5, 15))
}
21 changes: 21 additions & 0 deletions tests/baselines/reference/arrowFunctionMakesStrictLiteralCheck.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
=== tests/cases/compiler/arrowFunctionMakesStrictLiteralCheck.ts ===
interface X { x: number; }
>X : X
>x : number

type XGetter = () => X;
>XGetter : XGetter
>X : X

const getX2: XGetter = () => {
>getX2 : XGetter
>XGetter : XGetter
>() => { return { x: 1, y: 2 }; // Expect excess property error on `y`} : () => { x: number; y: number; }

return { x: 1, y: 2 }; // Expect excess property error on `y`
>{ x: 1, y: 2 } : { x: number; y: number; }
>x : number
>1 : 1
>y : number
>2 : 2
}
8 changes: 4 additions & 4 deletions tests/baselines/reference/assignmentCompatBug2.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ tests/cases/compiler/assignmentCompatBug2.ts(15,1): error TS2322: Type '{ f: (n:
Property 'm' is missing in type '{ f: (n: number) => number; g: (s: string) => number; }'.
tests/cases/compiler/assignmentCompatBug2.ts(20,1): error TS2322: Type '{ f: (n: number) => number; m: number; }' is not assignable to type '{ f(n: number): number; g(s: string): number; m: number; n?: number; k?(a: any): any; }'.
Property 'g' is missing in type '{ f: (n: number) => number; m: number; }'.
tests/cases/compiler/assignmentCompatBug2.ts(33,1): error TS2322: Type '{ f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => any; }' is not assignable to type '{ f(n: number): number; g(s: string): number; m: number; n?: number; k?(a: any): any; }'.
Property 'm' is missing in type '{ f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => any; }'.
tests/cases/compiler/assignmentCompatBug2.ts(33,1): error TS2322: Type '{ f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => null; }' is not assignable to type '{ f(n: number): number; g(s: string): number; m: number; n?: number; k?(a: any): any; }'.
Property 'm' is missing in type '{ f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => null; }'.


==== tests/cases/compiler/assignmentCompatBug2.ts (6 errors) ====
Expand Down Expand Up @@ -62,8 +62,8 @@ tests/cases/compiler/assignmentCompatBug2.ts(33,1): error TS2322: Type '{ f: (n:

b3 = {
~~
!!! error TS2322: Type '{ f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => any; }' is not assignable to type '{ f(n: number): number; g(s: string): number; m: number; n?: number; k?(a: any): any; }'.
!!! error TS2322: Property 'm' is missing in type '{ f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => any; }'.
!!! error TS2322: Type '{ f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => null; }' is not assignable to type '{ f(n: number): number; g(s: string): number; m: number; n?: number; k?(a: any): any; }'.
!!! error TS2322: Property 'm' is missing in type '{ f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => null; }'.
f: (n) => { return 0; },
g: (s) => { return 0; },
n: 0,
Expand Down
16 changes: 8 additions & 8 deletions tests/baselines/reference/assignmentCompatBug2.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ b3 = {
}; // error

b3 = {
>b3 = { f: (n) => { return 0; }, g: (s) => { return 0; }, m: 0, n: 0, k: (a) =>{ return null; },} : { f: (n: number) => number; g: (s: string) => number; m: number; n: number; k: (a: any) => any; }
>b3 = { f: (n) => { return 0; }, g: (s) => { return 0; }, m: 0, n: 0, k: (a) =>{ return null; },} : { f: (n: number) => number; g: (s: string) => number; m: number; n: number; k: (a: any) => null; }
>b3 : { f(n: number): number; g(s: string): number; m: number; n?: number; k?(a: any): any; }
>{ f: (n) => { return 0; }, g: (s) => { return 0; }, m: 0, n: 0, k: (a) =>{ return null; },} : { f: (n: number) => number; g: (s: string) => number; m: number; n: number; k: (a: any) => any; }
>{ f: (n) => { return 0; }, g: (s) => { return 0; }, m: 0, n: 0, k: (a) =>{ return null; },} : { f: (n: number) => number; g: (s: string) => number; m: number; n: number; k: (a: any) => null; }

f: (n) => { return 0; },
>f : (n: number) => number
Expand All @@ -118,17 +118,17 @@ b3 = {
>0 : 0

k: (a) =>{ return null; },
>k : (a: any) => any
>(a) =>{ return null; } : (a: any) => any
>k : (a: any) => null
>(a) =>{ return null; } : (a: any) => null
>a : any
>null : null

}; // ok

b3 = {
>b3 = { f: (n) => { return 0; }, g: (s) => { return 0; }, n: 0, k: (a) =>{ return null; },} : { f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => any; }
>b3 = { f: (n) => { return 0; }, g: (s) => { return 0; }, n: 0, k: (a) =>{ return null; },} : { f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => null; }
>b3 : { f(n: number): number; g(s: string): number; m: number; n?: number; k?(a: any): any; }
>{ f: (n) => { return 0; }, g: (s) => { return 0; }, n: 0, k: (a) =>{ return null; },} : { f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => any; }
>{ f: (n) => { return 0; }, g: (s) => { return 0; }, n: 0, k: (a) =>{ return null; },} : { f: (n: number) => number; g: (s: string) => number; n: number; k: (a: any) => null; }

f: (n) => { return 0; },
>f : (n: number) => number
Expand All @@ -147,8 +147,8 @@ b3 = {
>0 : 0

k: (a) =>{ return null; },
>k : (a: any) => any
>(a) =>{ return null; } : (a: any) => any
>k : (a: any) => null
>(a) =>{ return null; } : (a: any) => null
>a : any
>null : null

Expand Down
Loading