Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaboration in assignability errors for call expressions. #220

Closed
wants to merge 1 commit into from

Conversation

DanielRosenwasser
Copy link
Member

Fixes #93.

@ahejlsberg
Copy link
Member

An additional comment: I think the generic "Supplied parameters do not match..." message should only be reported when collectCandidates finds no candidates at all. Otherwise, the top level error should be a message of the form I suggest above.

@ahejlsberg
Copy link
Member

I think we're always better off picking one of the signatures (I like the last) and reporting the errors related to it. This is more likely to reveal the problem and provides a more consistent experience (i.e. you always get error details regardless of whether there are overloads).

ahejlsberg added a commit that referenced this pull request Jul 25, 2014
Fixes #93.
This is an evolution of #220.
@DanielRosenwasser
Copy link
Member Author

Resolved in #242.

@DanielRosenwasser DanielRosenwasser deleted the overloadResolutionErrors branch July 25, 2014 16:54
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Errors] Message quality degradation for overload resolution errors
3 participants