Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up FAR and NavTo aggregation #47938

Closed
wants to merge 3 commits into from
Closed

Clean up FAR and NavTo aggregation #47938

wants to merge 3 commits into from

Commits on Feb 17, 2022

  1. Start inlining helpers and renaming functions related to FAR/NavTo

    @amcasey
    amcasey committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    14afc16 View commit details
    Browse the repository at this point in the history

  2. Clean up navto 

    I'm generally okay with the test change (seeing fewer results when a file is specified) both in principal, since not loading projects seems preferable when scoping to the active document, and in practice, since AFAIK only old version of VS Code pass a file with no project.
    @amcasey
    amcasey committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    55f2a31 View commit details
    Browse the repository at this point in the history

  3. Clean up FAR and RenameLocations 

    This change had two goals:

1. Make the code easier to understand, primarily by simplifying the callback structure and minimizing side-effects
2. Improve performance by reducing repeated work, both FAR searches of individual projects and default tsconfig searches

Most of the baseline changes just reflect the de-duping of tsconfig searches, a few show fewer and occasionally different FAR invocations, and a couple show response changes.  I'm quite confident that the new FAR calls are better and moderately confident that the new isDefinition values are better (not to mention moderately skeptical that anyone will ever hit a case where the difference matters).
    @amcasey
    amcasey committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    00c0e9d View commit details
    Browse the repository at this point in the history