Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eslint-plugin-jsdoc by extending local jsdoc-format rule, saving ~20% of our linting time #51438

Merged
merged 4 commits into from
Nov 8, 2022

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Nov 8, 2022

I had to write an ESLint rule for our JSDoc comments in the module conversion anyway. Extend it to do some basic checking of the alignment of the comments, which is all we use the jsdoc plugin for. (To be clear, I wrote this logic from scratch; the jsdoc plugin probably does a lot more.)

Before:

npx eslint .  54.13s user 2.26s system 148% cpu 37.867 total

After:

npx eslint .  47.32s user 2.15s system 155% cpu 31.846 total

Probably deserves a test or two; I neglected writing any for my original rule.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 8, 2022
@sheetalkamat
Copy link
Member

Perf is always great

@jakebailey jakebailey marked this pull request as ready for review November 8, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants