Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smoke test substitution #51494

Merged
merged 3 commits into from
Nov 12, 2022
Merged

Fix smoke test substitution #51494

merged 3 commits into from
Nov 12, 2022

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Nov 11, 2022

I just merged the smoke test from #51464, but while it passed, I reread the logs on main and saw that it didn't actually work as expected; the heredoc wasn't in the right format and so was interpolating some of the code when I just wanted it raw.

Maybe I should just make it a script in the repo :\

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 11, 2022
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the ending sequence not need to change?

@jakebailey
Copy link
Member Author

Nope, this is some silly bashism where if you quote the string (single or double), then it won't interpolate the string, but the ending sequence is still the same. Annoying. https://stackoverflow.com/questions/22697688/how-to-cat-eof-a-file-containing-code

I tested it locally this time...

@jakebailey
Copy link
Member Author

Alright, there's now logging so one can see what it's doing, kinda like playwright. Which, begs the question as to whether or not I should be just making a smoke test script which tests all of that together instead, but that's another day.

@jakebailey jakebailey merged commit b553aff into microsoft:main Nov 12, 2022
@jakebailey jakebailey deleted the smoke-2 branch November 12, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants