Enforce identical enum values in compatibility checks #55924

DanielRosenwasser · 2023-09-30T03:35:51Z

This change proposes a new check for compatibility between two distinct enum declarations. On top of previous expectations around enum compatibility, where

the declared enum must have an identical name
each of the enum members in the source must have an enum member declared in the target with an identical name

this change checks that each enum member in the source must have a known value, and that value must have an identical known value in the target.

You can view some examples here.

// Example 1.
// Both declarations of `SomeEnum` should be compatible.
// All enum members have identical values.
namespace example1 {
    namespace First {
        export enum SomeEnum {
            A = 0,
            B = 1,
        }
    }

    namespace Second {
        export enum SomeEnum {
            A = 0,
            B = 1,
        }
    }

    function foo(x: First.SomeEnum, y: Second.SomeEnum) {
        x = y;
        y = x;
    }
}

// Example 2.
// Declarations of `SomeEnum` should be *incompatible*.
// The value of `SomeEnum.B` is different.
namespace example2 {
    namespace First {
        export enum SomeEnum {
            A = 0,
            B = 1,
        }
    }

    namespace Second {
        export enum SomeEnum {
            A = 0,
            B = 2,
        }
    }

    function foo(x: First.SomeEnum, y: Second.SomeEnum) {
        x = y;
//      ~~~~~ error!
//      Type 'Second.SomeEnum' is not assignable to type 'First.SomeEnum'.
//        Each declaration of 'SomeEnum.B' differs in its value,
//        where '1' was expected but '2' was given.
        y = x;
//      ~~~~~ error!
//      Type 'First.SomeEnum' is not assignable to type 'Second.SomeEnum'.
//        Each declaration of 'SomeEnum.B' differs in its value,
//        where '2' was expected but '1' was given.
    }
}

// Example 3.
// Declarations of `SomeEnum` should be *incompatible*.
// The value of `Second.SomeEnum.B` is not fully known because
// `Second.SomeEnum` is ambient and it does not specify a value for `B`.
namespace example3 {
    namespace First {
        export enum SomeEnum {
            A = 0,
            B,
        }
    }

    namespace Second {
        export declare enum SomeEnum {
            A = 0,
            B,
        }
    }

    function foo(x: First.SomeEnum, y: Second.SomeEnum) {
        x = y;
//      ~~~~~ error!
//      Type 'Second.SomeEnum' is not assignable to type 'First.SomeEnum'.
//        Values of 'SomeEnum.B' are not sufficiently known.
        y = x;
//      ~~~~~ error!
//      Type 'Second.SomeEnum' is not assignable to type 'First.SomeEnum'.
//        Values of 'SomeEnum.B' are not sufficiently known.
    }
}

// Example 4.
// Declarations of `SomeEnum` should be *incompatible*.
// The value of `Second.SomeEnum.B` is not fully known because
// all members are dynamically computed.
namespace example4 {
    declare function random(): number;

    namespace First {
        export enum SomeEnum {
            A = random(),
            B = random(),
        }
    }

    namespace Second {
        export enum SomeEnum {
            A = random(),
            B = random(),
        }
    }

    function foo(x: First.SomeEnum, y: Second.SomeEnum) {
//      ~~~~~ error!
//      Type 'Second.SomeEnum' is not assignable to type 'First.SomeEnum'.
//        Values of 'SomeEnum.A' are not sufficiently known.
        y = x;
//      ~~~~~ error!
//      Type 'Second.SomeEnum' is not assignable to type 'First.SomeEnum'.
//        Values of 'SomeEnum.A' are not sufficiently known.
    }
}

~~You can also see these in action in a recent playground build.~~

Important

This is an update that the aforementioned playground link and examples reflect older behavior where known values were incompatible with unknown values. Check the introduced tests to get a sense of the new behavior.

DanielRosenwasser · 2023-09-30T03:36:21Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top300
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2023-09-30T03:36:23Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 41e7790. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-30T03:36:23Z

Heya @DanielRosenwasser, I've started to run the regular perf test suite on this PR at 41e7790. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-30T03:36:23Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 41e7790. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-30T03:36:23Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 41e7790. You can monitor the build here.

typescript-bot · 2023-09-30T03:38:24Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158034/artifacts?artifactName=tgz&fileId=67DB04192934E1DD37668DD2D239A0103C85A5572F439C5A8870481CE0771FF302&fileName=/typescript-5.3.0-insiders.20230930.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-55924-5".;

typescript-bot · 2023-09-30T03:56:15Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,041k (± 0.01%)}	_{295,096k (± 0.01%)}	_{+56k (+ 0.02%)}	_295,066k	_295,139k	_{p=0.013 n=6}
_{Parse Time}	_{2.63s (± 0.88%)}	_{2.64s (± 0.20%)}	_~	_2.63s	_2.64s	_{p=0.797 n=6}
_{Bind Time}	_{0.84s (± 0.90%)}	_{0.84s (± 1.30%)}	_~	_0.83s	_0.85s	_{p=0.865 n=6}
_{Check Time}	_{8.06s (± 0.30%)}	_{8.06s (± 0.26%)}	_~	_8.04s	_8.09s	_{p=1.000 n=6}
_{Emit Time}	_{7.05s (± 0.42%)}	_{7.03s (± 0.42%)}	_~	_6.99s	_7.07s	_{p=0.294 n=6}
_{Total Time}	_{18.59s (± 0.21%)}	_{18.57s (± 0.19%)}	_~	_18.51s	_18.62s	_{p=0.809 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,080k (± 1.26%)}	_{192,660k (± 1.56%)}	_~	_190,702k	_196,603k	_{p=0.173 n=6}
_{Parse Time}	_{1.35s (± 0.87%)}	_{1.34s (± 0.47%)}	_~	_1.33s	_1.35s	_{p=0.177 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.24s (± 0.97%)}	_{9.17s (± 0.39%)}	_~	_9.13s	_9.23s	_{p=0.173 n=6}
_{Emit Time}	_{2.63s (± 0.48%)}	_{2.62s (± 0.95%)}	_~	_2.60s	_2.67s	_{p=0.157 n=6}
_{Total Time}	_{13.95s (± 0.64%)}	_{13.86s (± 0.27%)}	_{-0.08s (- 0.60%)}	_13.83s	_13.91s	_{p=0.043 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,318k (± 0.01%)}	_{347,306k (± 0.00%)}	_~	_347,286k	_347,317k	_{p=0.261 n=6}
_{Parse Time}	_{2.46s (± 0.66%)}	_{2.46s (± 0.48%)}	_~	_2.45s	_2.48s	_{p=0.805 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{6.90s (± 0.44%)}	_{6.92s (± 0.46%)}	_~	_6.89s	_6.98s	_{p=0.414 n=6}
_{Emit Time}	_{4.02s (± 0.48%)}	_{4.01s (± 0.47%)}	_~	_3.99s	_4.04s	_{p=0.627 n=6}
_{Total Time}	_{14.32s (± 0.27%)}	_{14.34s (± 0.21%)}	_~	_14.31s	_14.39s	_{p=0.575 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,541k (± 0.01%)}	_{302,550k (± 0.00%)}	_~	_302,532k	_302,563k	_{p=0.261 n=6}
_{Parse Time}	_{1.99s (± 0.53%)}	_{2.00s (± 0.88%)}	_{+0.02s (+ 1.01%)}	_1.98s	_2.03s	_{p=0.048 n=6}
_{Bind Time}	_{1.01s (± 1.22%)}	_{1.00s (± 1.22%)}	_~	_0.99s	_1.02s	_{p=1.000 n=6}
_{Check Time}	_{6.25s (± 0.53%)}	_{6.25s (± 0.46%)}	_~	_6.21s	_6.29s	_{p=0.936 n=6}
_{Emit Time}	_{3.56s (± 0.68%)}	_{3.57s (± 0.41%)}	_~	_3.55s	_3.59s	_{p=0.627 n=6}
_{Total Time}	_{12.81s (± 0.35%)}	_{12.82s (± 0.29%)}	_~	_12.77s	_12.88s	_{p=0.629 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,492k (± 0.00%)}	_{470,499k (± 0.00%)}	_~	_470,468k	_470,537k	_{p=0.748 n=6}
_{Parse Time}	_{2.58s (± 0.45%)}	_{2.58s (± 0.68%)}	_~	_2.55s	_2.60s	_{p=0.680 n=6}
_{Bind Time}	_{0.99s (± 0.82%)}	_{1.00s (± 1.05%)}	_~	_0.98s	_1.01s	_{p=0.865 n=6}
_{Check Time}	_{16.60s (± 0.43%)}	_{16.57s (± 0.45%)}	_~	_16.49s	_16.68s	_{p=0.688 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.17s (± 0.40%)}	_{20.14s (± 0.35%)}	_~	_20.06s	_20.25s	_{p=0.575 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,562k (± 0.01%)}	_{512,573k (± 0.01%)}	_~	_512,497k	_512,675k	_{p=0.810 n=6}
_{Parse Time}	_{3.26s (± 0.41%)}	_{3.27s (± 0.16%)}	_~	_3.26s	_3.27s	_{p=0.437 n=6}
_{Bind Time}	_{1.55s (± 0.26%)}	_{1.55s (± 0.41%)}	_~	_1.54s	_1.56s	_{p=0.673 n=6}
_{Check Time}	_{2.88s (± 0.48%)}	_{2.88s (± 1.31%)}	_~	_2.83s	_2.92s	_{p=1.000 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.76s (± 0.19%)}	_{7.77s (± 0.49%)}	_~	_7.72s	_7.81s	_{p=0.624 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,372ms (± 1.64%)}	_{2,403ms (± 1.06%)}	_~	_2,352ms	_2,419ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{5,356ms (± 1.63%)}	_{5,297ms (± 0.31%)}	_~	_5,275ms	_5,315ms	_{p=0.296 n=6}
_{Req 3 - references}	_{331ms (± 1.25%)}	_{343ms (± 8.00%)}	_~	_326ms	_398ms	_{p=0.520 n=6}
_{Req 4 - navto}	_{277ms (± 0.74%)}	_{277ms (± 1.90%)}	_~	_267ms	_283ms	_{p=0.739 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 8.93%)}	_{77ms (± 5.45%)}	_~	_74ms	_85ms	_{p=0.933 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,470ms (± 0.50%)}	_{2,470ms (± 0.72%)}	_~	_2,437ms	_2,489ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,105ms (± 1.75%)}	_{4,081ms (± 1.44%)}	_~	_4,048ms	_4,200ms	_{p=0.575 n=6}
_{Req 3 - references}	_{337ms (± 1.28%)}	_{340ms (± 1.54%)}	_~	_332ms	_344ms	_{p=0.256 n=6}
_{Req 4 - navto}	_{284ms (± 0.29%)}	_{284ms (± 0.59%)}	_~	_282ms	_287ms	_{p=0.866 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 6.82%)}	_{83ms (± 7.14%)}	_~	_75ms	_87ms	_{p=0.342 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,590ms (± 0.44%)}	_{2,596ms (± 0.54%)}	_~	_2,577ms	_2,614ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{1,705ms (± 3.02%)}	_{1,687ms (± 2.88%)}	_~	_1,619ms	_1,742ms	_{p=0.471 n=6}
_{Req 3 - references}	_{109ms (± 7.82%)}	_{106ms (± 1.25%)}	_~	_104ms	_108ms	_{p=0.735 n=6}
_{Req 4 - navto}	_{359ms (± 0.29%)}	_{360ms (± 0.37%)}	_~	_358ms	_362ms	_{p=0.098 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{305ms (± 2.03%)}	_{305ms (± 2.68%)}	_~	_295ms	_318ms	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.34ms (± 0.18%)}	_{152.11ms (± 0.15%)}	_{-0.23ms (- 0.15%)}	_151.14ms	_154.47ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.11ms (± 0.17%)}	_{226.88ms (± 0.17%)}	_{-0.23ms (- 0.10%)}	_225.55ms	_230.75ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.95ms (± 0.16%)}	_{228.95ms (± 0.16%)}	_~	_227.17ms	_233.82ms	_{p=0.689 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.44ms (± 0.16%)}	_{228.51ms (± 0.16%)}	_~	_226.95ms	_232.28ms	_{p=0.158 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-30T05:03:38Z

Hey @DanielRosenwasser, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-09-30T06:33:24Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/55924/merge:

Everything looks good!

sandersn

I think this is worth trying for 5.4.

sandersn · 2023-10-27T22:39:40Z

src/compiler/diagnosticMessages.json

@@ -4132,6 +4132,10 @@
        "category": "Error",
        "code": 4124
    },
+    "The values of '{0}.{1}' differ in their declarations, where '{2}' was expected but '{3}' was given.": {


'First.E.c' has value '2' but 'Decl.E.c' has value '3'.

Suggested change

"The values of '{0}.{1}' differ in their declarations, where '{2}' was expected but '{3}' was given.": {

"'{0}.{1}' has value '{2}', but '{3}.{1}' has value '{4}'.": {

The problem is that each of them have identical names between members and enums 😄

Unless I fully qualified the name - but the earlier error message will have done that anyway.

I agree with Nathan's suggestion that it would be better to use the fully qualified names when talking about the members and the different values, even though you can figure it out with the current error message + elaboration.

It's definitely redundant, but the redundancy makes it easier to read in this case because there's less context to piece together, and less work to do overall to read the message.

tests/baselines/reference/enumAssignmentCompat3.errors.txt

DanielRosenwasser · 2023-11-03T23:12:10Z

@typescript-bot test this
@typescript-bot test top300
@typescript-bot run dt

typescript-bot · 2023-11-03T23:12:13Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at b2033b3. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-16T23:08:37Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/55924/merge:

Everything looks good!

DanielRosenwasser · 2023-12-07T01:07:33Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top300
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2023-12-07T01:07:36Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at af7f5b8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-07T01:07:36Z

Heya @DanielRosenwasser, I've started to run the regular perf test suite on this PR at af7f5b8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-07T01:07:36Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at af7f5b8. You can monitor the build here.

typescript-bot · 2023-12-07T01:07:36Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at af7f5b8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-07T01:09:32Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158992/artifacts?artifactName=tgz&fileId=2722BB2A780D85F3D4B196A2255D19D8292C1A506716247F2DAB09B95737127B02&fileName=/typescript-5.4.0-insiders.20231207.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-55924-28".;

typescript-bot · 2023-12-07T01:28:08Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,371k (± 0.01%)}	_{295,365k (± 0.01%)}	_~	_295,318k	_295,428k	_{p=0.810 n=6}
_{Parse Time}	_{2.65s (± 0.32%)}	_{2.65s (± 0.19%)}	_~	_2.64s	_2.65s	_{p=0.923 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.00%)}	_~	_0.82s	_0.82s	_{p=0.405 n=6}
_{Check Time}	_{8.12s (± 0.29%)}	_{8.12s (± 0.15%)}	_~	_8.11s	_8.14s	_{p=0.871 n=6}
_{Emit Time}	_{7.09s (± 0.25%)}	_{7.08s (± 0.19%)}	_~	_7.05s	_7.09s	_{p=0.304 n=6}
_{Total Time}	_{18.68s (± 0.18%)}	_{18.67s (± 0.10%)}	_~	_18.64s	_18.69s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,374k (± 1.23%)}	_{191,817k (± 0.55%)}	_~	_191,373k	_193,965k	_{p=0.336 n=6}
_{Parse Time}	_{1.36s (± 0.93%)}	_{1.36s (± 0.89%)}	_~	_1.35s	_1.38s	_{p=0.675 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 1.13%)}	_~	_0.72s	_0.74s	_{p=0.405 n=6}
_{Check Time}	_{9.27s (± 0.41%)}	_{9.27s (± 0.36%)}	_~	_9.22s	_9.32s	_{p=0.687 n=6}
_{Emit Time}	_{2.62s (± 0.37%)}	_{2.62s (± 0.56%)}	_~	_2.59s	_2.63s	_{p=0.865 n=6}
_{Total Time}	_{13.98s (± 0.36%)}	_{13.97s (± 0.31%)}	_~	_13.94s	_14.05s	_{p=0.570 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,375k (± 0.00%)}	_{347,380k (± 0.00%)}	_~	_347,366k	_347,396k	_{p=0.936 n=6}
_{Parse Time}	_{2.46s (± 0.81%)}	_{2.45s (± 0.66%)}	_~	_2.43s	_2.47s	_{p=0.684 n=6}
_{Bind Time}	_{0.92s (± 0.56%)}	_{0.93s (± 0.44%)}	_~	_0.92s	_0.93s	_{p=0.112 n=6}
_{Check Time}	_{6.90s (± 0.39%)}	_{6.92s (± 0.65%)}	_~	_6.88s	_7.00s	_{p=0.518 n=6}
_{Emit Time}	_{4.04s (± 0.43%)}	_{4.06s (± 0.48%)}	_~	_4.04s	_4.09s	_{p=0.164 n=6}
_{Total Time}	_{14.33s (± 0.28%)}	_{14.36s (± 0.34%)}	_~	_14.30s	_14.42s	_{p=0.198 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,628k (± 0.00%)}	_{302,644k (± 0.00%)}	_~	_302,627k	_302,653k	_{p=0.078 n=6}
_{Parse Time}	_{1.99s (± 0.93%)}	_{2.00s (± 0.99%)}	_~	_1.96s	_2.02s	_{p=0.411 n=6}
_{Bind Time}	_{1.01s (± 0.97%)}	_{1.00s (± 1.17%)}	_~	_0.99s	_1.02s	_{p=0.314 n=6}
_{Check Time}	_{6.30s (± 0.33%)}	_{6.28s (± 0.33%)}	_~	_6.25s	_6.31s	_{p=0.222 n=6}
_{Emit Time}	_{3.57s (± 0.47%)}	_{3.59s (± 0.35%)}	_{+0.02s (+ 0.56%)}	_3.58s	_3.61s	_{p=0.040 n=6}
_{Total Time}	_{12.88s (± 0.25%)}	_{12.87s (± 0.27%)}	_~	_12.82s	_12.91s	_{p=0.936 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{506,741k (± 0.01%)}	_{506,759k (± 0.00%)}	_~	_506,741k	_506,797k	_{p=0.335 n=6}
_{Parse Time}	_{2.57s (± 0.32%)}	_{2.58s (± 0.53%)}	_~	_2.56s	_2.60s	_{p=0.858 n=6}
_{Bind Time}	_{1.00s (± 1.09%)}	_{0.99s (± 1.18%)}	_~	_0.98s	_1.01s	_{p=0.246 n=6}
_{Check Time}	_{16.86s (± 0.30%)}	_{16.82s (± 0.18%)}	_~	_16.79s	_16.87s	_{p=0.191 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.44s (± 0.23%)}	_{20.39s (± 0.17%)}	_~	_20.34s	_20.43s	_{p=0.107 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,707k (± 0.01%)}	_{512,721k (± 0.01%)}	_~	_512,663k	_512,795k	_{p=0.936 n=6}
_{Parse Time}	_{3.28s (± 0.25%)}	_{3.28s (± 0.31%)}	_~	_3.27s	_3.30s	_{p=0.270 n=6}
_{Bind Time}	_{1.53s (± 0.34%)}	_{1.54s (± 0.49%)}	_~	_1.53s	_1.55s	_{p=0.069 n=6}
_{Check Time}	_{2.80s (± 0.45%)}	_{2.79s (± 0.45%)}	_~	_2.78s	_2.81s	_{p=0.187 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.69s (± 0.15%)}	_{7.69s (± 0.28%)}	_~	_7.67s	_7.72s	_{p=0.807 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,346ms (± 0.59%)}	_{2,342ms (± 0.25%)}	_~	_2,336ms	_2,353ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{5,399ms (± 1.51%)}	_{5,411ms (± 1.85%)}	_~	_5,335ms	_5,541ms	_{p=0.689 n=6}
_{Req 3 - references}	_{326ms (± 1.46%)}	_{323ms (± 1.17%)}	_~	_320ms	_330ms	_{p=0.142 n=6}
_{Req 4 - navto}	_{278ms (± 1.03%)}	_{278ms (± 1.26%)}	_~	_273ms	_280ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 6.05%)}	_{86ms (± 5.88%)}	_~	_82ms	_93ms	_{p=0.273 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,471ms (± 1.12%)}	_{2,463ms (± 1.21%)}	_~	_2,433ms	_2,514ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{4,132ms (± 2.28%)}	_{4,139ms (± 1.99%)}	_~	_4,053ms	_4,222ms	_{p=0.575 n=6}
_{Req 3 - references}	_{342ms (± 1.47%)}	_{342ms (± 1.42%)}	_~	_335ms	_346ms	_{p=0.936 n=6}
_{Req 4 - navto}	_{287ms (± 1.46%)}	_{286ms (± 1.01%)}	_~	_283ms	_291ms	_{p=0.517 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 7.90%)}	_{85ms (± 7.17%)}	_~	_77ms	_90ms	_{p=0.623 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,595ms (± 0.69%)}	_{2,612ms (± 0.31%)}	_~	_2,597ms	_2,618ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{1,683ms (± 2.22%)}	_{1,690ms (± 1.73%)}	_~	_1,647ms	_1,720ms	_{p=0.936 n=6}
_{Req 3 - references}	_{112ms (± 9.29%)}	_{115ms (± 8.53%)}	_~	_102ms	_123ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{368ms (± 2.39%)}	_{365ms (± 0.41%)}	_~	_363ms	_367ms	_{p=0.743 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{305ms (± 2.04%)}	_{308ms (± 1.56%)}	_~	_301ms	_313ms	_{p=0.377 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.94ms (± 0.22%)}	_{152.85ms (± 0.20%)}	_{-0.09ms (- 0.06%)}	_151.79ms	_155.54ms	_{p=0.004 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.46ms (± 0.17%)}	_{228.41ms (± 0.14%)}	_~	_227.00ms	_231.60ms	_{p=0.252 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.70ms (± 0.19%)}	_{229.75ms (± 0.18%)}	_~	_228.03ms	_233.30ms	_{p=0.079 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.34ms (± 0.18%)}	_{229.40ms (± 0.18%)}	_~	_227.95ms	_235.79ms	_{p=0.058 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-12-07T02:00:07Z

Hey @DanielRosenwasser, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-12-07T04:09:50Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/55924/merge:

Everything looks good!

src/compiler/checker.ts

DanielRosenwasser added 4 commits September 30, 2023 03:14

Add test for enum compatibility between string/number enums.

4b3c52b

Accepted baselines.

26aa2dc

Add error when enum values differ.

35f3b9f

Accepted baselines.

41e7790

typescript-bot assigned DanielRosenwasser Sep 30, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 30, 2023

DanielRosenwasser marked this pull request as ready for review October 2, 2023 05:09

sandersn self-requested a review October 27, 2023 22:24

sandersn approved these changes Nov 2, 2023

View reviewed changes

Rephrase error message.

e476157

DanielRosenwasser commented Nov 3, 2023

View reviewed changes

tests/baselines/reference/enumAssignmentCompat3.errors.txt Outdated Show resolved Hide resolved

DanielRosenwasser added 4 commits November 3, 2023 22:35

Update tests.

21f2794

Accept baselines.

2db2773

Error on undefined values.

e7da702

Accept baseline.

b2033b3

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 17, 2023

DanielRosenwasser mentioned this pull request Nov 17, 2023

Design Meeting Notes, 11/17/2023 #56450

Closed

DanielRosenwasser added 5 commits December 7, 2023 00:54

Add test cases around ambient enum members.

fad8d30

Accepted baselines.

29b68f5

Only error on undefined values when the other is a string.

b594281

Accepted baselines.

cd2d86e

Only do work for error reporting if there's an error reporter.

af7f5b8

DanielRosenwasser requested review from sandersn and gabritto December 7, 2023 01:07

gabritto approved these changes Dec 7, 2023

View reviewed changes

DanielRosenwasser commented Dec 15, 2023

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

DanielRosenwasser added 3 commits December 19, 2023 22:20

Move around comments.

aeeb7da

Add some tests that include a bidirectional enum check.

2f075c1

Accept baselines.

91e3ac6

DanielRosenwasser merged commit 93e6b9d into main Dec 20, 2023
19 checks passed

DanielRosenwasser deleted the enum-value-checks branch December 20, 2023 21:52

DanielRosenwasser added this to the TypeScript 5.4.0 milestone Dec 20, 2023

nazarhussain mentioned this pull request Mar 15, 2024

deps: upgrade typescript to 5.4 ChainSafe/lodestar#6552

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enforce identical enum values in compatibility checks #55924

Enforce identical enum values in compatibility checks #55924

DanielRosenwasser commented Sep 30, 2023 •

edited

Loading

DanielRosenwasser commented Sep 30, 2023

typescript-bot commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Sep 30, 2023

Compiler

tsserver

Startup

typescript-bot commented Sep 30, 2023

typescript-bot commented Sep 30, 2023

sandersn left a comment

sandersn Oct 27, 2023

DanielRosenwasser Nov 3, 2023

DanielRosenwasser Nov 3, 2023

gabritto Nov 6, 2023

sandersn Nov 16, 2023

DanielRosenwasser commented Nov 3, 2023

typescript-bot commented Nov 3, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023

DanielRosenwasser commented Dec 7, 2023

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023

Compiler

tsserver

Startup

typescript-bot commented Dec 7, 2023

typescript-bot commented Dec 7, 2023

	"The values of '{0}.{1}' differ in their declarations, where '{2}' was expected but '{3}' was given.": {
	"'{0}.{1}' has value '{2}', but '{3}.{1}' has value '{4}'.": {

Enforce identical enum values in compatibility checks #55924

Enforce identical enum values in compatibility checks #55924

Conversation

DanielRosenwasser commented Sep 30, 2023 • edited Loading

DanielRosenwasser commented Sep 30, 2023

typescript-bot commented Sep 30, 2023 • edited Loading

typescript-bot commented Sep 30, 2023 • edited Loading

typescript-bot commented Sep 30, 2023 • edited Loading

typescript-bot commented Sep 30, 2023 • edited Loading

typescript-bot commented Sep 30, 2023 • edited Loading

typescript-bot commented Sep 30, 2023

Compiler

tsserver

Startup

typescript-bot commented Sep 30, 2023

typescript-bot commented Sep 30, 2023

sandersn left a comment

Choose a reason for hiding this comment

sandersn Oct 27, 2023

Choose a reason for hiding this comment

DanielRosenwasser Nov 3, 2023

Choose a reason for hiding this comment

DanielRosenwasser Nov 3, 2023

Choose a reason for hiding this comment

gabritto Nov 6, 2023

Choose a reason for hiding this comment

sandersn Nov 16, 2023

Choose a reason for hiding this comment

DanielRosenwasser commented Nov 3, 2023

typescript-bot commented Nov 3, 2023 • edited Loading

typescript-bot commented Nov 16, 2023

DanielRosenwasser commented Dec 7, 2023

typescript-bot commented Dec 7, 2023 • edited Loading

typescript-bot commented Dec 7, 2023 • edited Loading

typescript-bot commented Dec 7, 2023 • edited Loading

typescript-bot commented Dec 7, 2023 • edited Loading

typescript-bot commented Dec 7, 2023 • edited Loading

typescript-bot commented Dec 7, 2023

Compiler

tsserver

Startup

typescript-bot commented Dec 7, 2023

typescript-bot commented Dec 7, 2023

DanielRosenwasser commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Sep 30, 2023 •

edited

Loading

typescript-bot commented Nov 3, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading