Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

feat: Korean language support #950

Merged
merged 11 commits into from
Apr 27, 2020
Merged

Conversation

aykhara
Copy link
Contributor

@aykhara aykhara commented Mar 25, 2020

Korean translation verified by @angie4u

Copy link
Contributor

@mydiemho mydiemho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you build the app locally to make sure all the strings are rendered correctly?

@aykhara
Copy link
Contributor Author

aykhara commented Mar 27, 2020

@mydiemho Thank you for taking the time to review this. Yes, I have built the app locally and worked correctly with all the strings on my side.

@angie4u
Copy link
Contributor

angie4u commented Mar 27, 2020

Yeap! I also checked my side as well and it works fine! :)
I'm adding few screenshots on this ;)
image

image

image

image

@mydiemho
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mydiemho
Copy link
Contributor

Codecov is having issues updating GitHub again. Going to bypass and merge since the report show that coverage report is good https://codecov.io/gh/microsoft/VoTT/tree/058354be8e1be7a9a01b9f38314ebb2055796a39

@mydiemho mydiemho merged commit 2b68e21 into microsoft:develop Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants