Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Runtime Identifier Paths for Compatibility with .NET 8 #4612

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

ShashankNay
Copy link
Contributor

@ShashankNay ShashankNay commented Aug 1, 2024

This PR addresses a warning that occurs when targeting .NET 8 in projects using the Microsoft.WindowsAppSDK. The warning, identified as NETSDK1206, is triggered due to the use of version-specific or distribution-specific runtime identifiers (RIDs) like win10-arm64, win10-x64, and win10-x86. In .NET 8 and higher, these RIDs are not recognized by default, leading to potential issues in locating necessary assets. The runtime identifier paths have been modified from win10-$Platform to win-$Platform to align with the new RID scheme in .NET 8.

@ShashankNay ShashankNay closed this Aug 1, 2024
@ShashankNay ShashankNay reopened this Aug 1, 2024
@ShashankNay ShashankNay marked this pull request as ready for review August 1, 2024 21:17
@ShashankNay ShashankNay changed the title removing runtime/win10-* artifacts Update Runtime Identifier Paths for Compatibility with .NET 8 Aug 1, 2024
@ShashankNay ShashankNay enabled auto-merge (squash) August 1, 2024 21:49
@ShashankNay
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ShashankNay ShashankNay merged commit 95624de into main Aug 2, 2024
27 checks passed
@ShashankNay ShashankNay deleted the user/shasnayak/netsdk-1206-fix branch August 2, 2024 17:54
ShashankNay added a commit that referenced this pull request Aug 7, 2024
Co-authored-by: Shashank Nayak <shasnayak@microsoft.com>
ShashankNay added a commit that referenced this pull request Aug 9, 2024
Co-authored-by: Shashank Nayak <shasnayak@microsoft.com>
kythant pushed a commit that referenced this pull request Aug 15, 2024
Co-authored-by: Shashank Nayak <shasnayak@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants