Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Source Link information so it points to Github rather than internal AzDO mirror #4666

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

evelynwu-msft
Copy link
Contributor

@evelynwu-msft evelynwu-msft commented Aug 21, 2024

This repository is mirrored onto an internal Azure DevOps repository that is used for building Windows App SDK releases. This has the unfortunate side effect of embedding into the PDB symbols Source Link information that points at the internal AzDO repo rather than this public Github repo. This change addresses that by adding a custom target that corrects the repo URL that Source Link uses.

Fixes #4633.

@evelynwu-msft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@evelynwu-msft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@evelynwu-msft evelynwu-msft merged commit a820af7 into main Aug 21, 2024
23 checks passed
@evelynwu-msft evelynwu-msft deleted the user/evelynwu/mrtcore-sourcelink branch August 21, 2024 18:52
evelynwu-msft added a commit that referenced this pull request Aug 21, 2024
…al AzDO mirror (#4666)

This repository is mirrored onto an internal Azure DevOps repository that is used for building Windows App SDK releases. This has the unfortunate side effect of embedding into the PDB symbols Source Link information that points at the internal AzDO repo rather than this public Github repo. This change addresses that by adding a custom target that corrects the repo URL that Source Link uses.

Fixes #4633.

(cherry picked from commit a820af7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDBs for MRT Core are missing source server information
2 participants