Fix centrally-versioned package references #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kythant
approved these changes
Aug 22, 2024
|
Do you have one for the main branch coming? |
Not yet but I'll do it soon. Tracking with bug 53411362. |
JesseCol
added a commit
that referenced
this pull request
Aug 22, 2024
* Use CentralPackageVersions in VSIX projects * Turns out we just need to make sure to import the Directory.Build.props at the root * Revert "Use CentralPackageVersions in VSIX projects" This reverts commit 3446e0c. * Don't include the entire root Directory.build.props
JesseCol
added a commit
that referenced
this pull request
Aug 23, 2024
* Use CentralPackageVersions in VSIX projects * Turns out we just need to make sure to import the Directory.Build.props at the root * Revert "Use CentralPackageVersions in VSIX projects" This reverts commit 3446e0c. * Don't include the entire root Directory.build.props
JesseCol
added a commit
that referenced
this pull request
Aug 23, 2024
* Use CentralPackageVersions in VSIX projects * Turns out we just need to make sure to import the Directory.Build.props at the root * Revert "Use CentralPackageVersions in VSIX projects" This reverts commit 3446e0c. * Don't include the entire root Directory.build.props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the projects under the VSIX folder, the build stopped honoring the "Directory.Packages.props" file at the root of the repo. This causes us to pick up old versions of all these packages, and hilarity ensues.
I'm not sure at the moment what caused this change in behavior, but this fix looks safe as we continue to investigate.