graph::CreateUser - Unable to specify correct UserCreationContext

[tiwood]

To create a user with graph.CreateUser we have to provide CreateUserArgs:

// Arguments for the CreateUser function
type CreateUserArgs struct {
	// (required) The subset of the full graph user used to uniquely find the graph subject in an external provider.
	CreationContext *GraphUserCreationContext
	// (optional) A comma separated list of descriptors of groups you want the graph user to join
	GroupDescriptors *[]string
}

The CreationContext decides if we create an aad, ad or msa account, but the current implementation only allows us to use the following context (which shouldn't be used):

// Do not attempt to use this type to create a new user. Use one of the subclasses instead. This type does not contain sufficient fields to create a new user.
type GraphUserCreationContext struct {
	// Optional: If provided, we will use this identifier for the storage key of the created user
	StorageKey *uuid.UUID `json:"storageKey,omitempty"`
}

Instead we should be able to provide one of the following:

type GraphUserPrincipalNameCreationContext struct {
	// Optional: If provided, we will use this identifier for the storage key of the created user
	StorageKey *uuid.UUID `json:"storageKey,omitempty"`
	// This should be the principal name or upn of the user in the source AD or AAD provider. Example: jamal@contoso.com Team Services will communicate with the source provider to fill all other fields on creation.
	PrincipalName *string `json:"principalName,omitempty"`
}

type GraphUserMailAddressCreationContext struct {
	// Optional: If provided, we will use this identifier for the storage key of the created user
	StorageKey  *uuid.UUID `json:"storageKey,omitempty"`
	MailAddress *string    `json:"mailAddress,omitempty"`
}

[tedchamb]

Thanks @tiwood , this is an issue where Go's lack of inheritance makes this difficult to address in the code generator. This is going to affect any method that accepts different subclasses as input. Fortunately there are not a lot of methods that fall into this category. I have a plan on how to fix this, but not sure when I will be able to get to it. Can you give me an idea of the priority of this particular issue for your application?

Thanks,
Ted

[tedchamb]

The GraphClient is meant to replace the IdentityClient, but the IdentityClient still works. Until this issue is fixed, you may want to try the CreateIdentity method on the IdentityClient.

[tmeckel]

@tedchamb is it possible to change the signature of the CreateUser method as follows (making parameter args generic)?

func (client *ClientImpl) CreateUser(ctx context.Context, args interface{}) (*GraphUser, error) {

and then checking in the method body for valid struct types?

[tmeckel]

The GraphClient is meant to replace the IdentityClient, but the IdentityClient still works. Until this issue is fixed, you may want to try the CreateIdentity method on the IdentityClient.

@tedchamb as we have the same issue with creating Groups via the Graph API I wanted to use the CreateGroups function from the Indentity API. The following structure must be passed as argument to CreateGroups

// Arguments for the CreateGroups function
type CreateGroupsArgs struct {
	// (required)
	Container interface{}
}

But because an interface{} is used as type for the Container struct element and there's no further description on this, I'm unable to use the CreateGroups method.

[nechvatalp]

I attempted to fix this in the latest 7.1 release by providing by providing more variants of the methods each accepting different context.

I added such "overloads" for both Users and Groups, I was able to call create user successfully with that.