Fix query editor smoke test race condition #6213
Conversation
| import * as fs from 'fs'; | ||
| import * as os from 'os'; | ||
| import * as path from 'path'; | ||
|
|
||
| export function setup() { | ||
| describe('Query Editor Test Suite', () => { | ||
| before(async function () { |
There was a problem hiding this comment.
I'm not sure why this would change anything. This is already done here
azuredatastudio/test/smoke/src/main.ts
Line 256 in dce115f
There was a problem hiding this comment.
Well shoot, yeah I saw that but for some reason thought we were doing a reload of the app after waiting. The issue is definitely because focus is being taken from the query window though - although why that's happening after the service should be done downloading I'm not sure...it doesn't repro consistently enough to really help here.
I'll try changing it to just specifically focus the query pane before typing the text - that should also solve the problem unless the focus stealing is happening even after the download is finished.
There was a problem hiding this comment.
it this is being caused because of the service downloading, you could change the output channel logic in the extensions to not continuously open the output log. https://github.com/microsoft/azuredatastudio/blob/master/extensions/mssql/src/main.ts#L365 I have been thinking about doing this, but its been low pri since it has no user impact on our releases since we never download new service binaries for releases.
Should fix #6110 - see comment for explanation