Merge pull request #935 from microsoft/users/shaopeng-gh/fix2004bug

Fix BA2004 bug creating error with empty list
microsoft · Jul 27, 2023 · a3795dc · a3795dc
2 parents 92148ab + 1b7985a
commit a3795dc
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/src/BinSkim.Rules/PERules/BA2004.EnableSecureSourceCodeHashing.cs b/src/BinSkim.Rules/PERules/BA2004.EnableSecureSourceCodeHashing.cs
@@ -252,17 +252,20 @@ private void GenerateCompilandsAndLog(BinaryAnalyzerContext context, Dictionary<
                 compilandsWithOneOrMoreInsecureFileHashes.Remove(HashType.None);
             }
 
-            string[] messages = new string[compilandsWithOneOrMoreInsecureFileHashes.Count];
-
-            int hashTypeCount = 0;
-            foreach (HashType hashType in compilandsWithOneOrMoreInsecureFileHashes.Keys)
+            if (compilandsWithOneOrMoreInsecureFileHashes.Count > 0)
             {
-                objectModuleDetails = compilandsWithOneOrMoreInsecureFileHashes[hashType];
-                messages[hashTypeCount++] = objectModuleDetails.CreateOutputCoalescedByCompiler(hashType.ToString());
-            }
+                string[] messages = new string[compilandsWithOneOrMoreInsecureFileHashes.Count];
+
+                int hashTypeCount = 0;
+                foreach (HashType hashType in compilandsWithOneOrMoreInsecureFileHashes.Keys)
+                {
+                    objectModuleDetails = compilandsWithOneOrMoreInsecureFileHashes[hashType];
+                    messages[hashTypeCount++] = objectModuleDetails.CreateOutputCoalescedByCompiler(hashType.ToString());
+                }
 
-            message = string.Join(Environment.NewLine, messages);
-            GenerateCompilandsAndLog(context, message, failureLevel);
+                message = string.Join(Environment.NewLine, messages);
+                GenerateCompilandsAndLog(context, message, failureLevel);
+            }
         }
 
         private void GenerateCompilandsAndLog(BinaryAnalyzerContext context, string message, FailureLevel failureLevel)