Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds check to TranscriptLoggerMiddleware doesn't log continue conversation event activities #4797

Merged
merged 3 commits into from
Oct 19, 2020
Merged

Adds check to TranscriptLoggerMiddleware doesn't log continue conversation event activities #4797

merged 3 commits into from
Oct 19, 2020

Commits on Oct 14, 2020

  1. Adds check to TranscriptLoggerMiddleware doesn't log contine conversa… 

    …tion event activities.

Changes include:
- Added check in TranscriptLoggerMiddleware to filter incoming ContinueConversation events.
- Introduced EventActivityNames class with constant strings for ContinueConversation so we don't have those strings hardcoded.
- Added also CreateConversation to the EventActivityNames helper (not related to this issue but saw it and decided to add it since it is better to have constants).
- Refactored ConversationReferenceEx to use the new constant (and use more straightforward code to create the event).
- Added tests for new logic in TranscriptLoggerMiddleware.
- Updated Skills testing projects to use the new constant
    @gabog
    gabog committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    a170519 View commit details
    Browse the repository at this point in the history

  2. Renamed EventActivityNames to ActivityEventNames

    @gabog
    gabog committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    68085ec View commit details
    Browse the repository at this point in the history

  3. Updated a couple of files that I missed after the rename.

    @gabog
    gabog committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    91efeef View commit details
    Browse the repository at this point in the history