Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Remove the ligratures for *) symbol #443

Closed
vosaica opened this issue Apr 7, 2021 · 7 comments · Fixed by #482
Closed

Feature Request: Remove the ligratures for *) symbol #443

vosaica opened this issue Apr 7, 2021 · 7 comments · Fixed by #482
Labels
Issue-Feature

Comments

@vosaica
Copy link

vosaica commented Apr 7, 2021

Description of the new feature/enhancement

When using the function pointer in C++ with VSCode, the asterisk will not be in the middle of the brackets. Especially when I am using the bracket colorizer plugin, the right bracket will not be colored to match the left bracket.
image

This also happens in my CLion, so it was not caused by VSCode

image

This problem won't appear when using other fonts that enable the ligatures
Fira Code:

image

JetBrains Mono:

image
@DHowett
Copy link
Member

DHowett commented Apr 7, 2021

We may instead want to suppress the ligature when it is adjacent to a (.

@aaronbell
Copy link
Collaborator

Yeah. That’s easy enough to add in :)

@vosaica
Copy link
Author

vosaica commented Apr 7, 2021

We may instead want to suppress the ligature when it is adjacent to a (.

Sure, I think it will be even better😄

@microsoft microsoft deleted a comment from abdullahaloo Apr 21, 2021
@ExE-Boss
Copy link

Or how about a ligature for (*)?

@Nahor
Copy link

Nahor commented May 21, 2021

Or how about a ligature for (*)?

I assume that would break everything based on bracket matching (e.g. bracket colorizer plugin mentioned in the issue description)

@aaronbell aaronbell mentioned this issue May 27, 2021
Merged
13 tasks
DHowett pushed a commit that referenced this issue May 28, 2021
@aaronbell
Cascadia Code Upright bugfixes (#482)
b0a6b2a 
A large set of bug fixes identified while working on the Italic, but solving
Github reported issues. 

## PR Checklist
- [x] Closes #422 - Bitcoin added
- [x] Closes #427 - FFFD glyph added
- [x] Closes #418 - top bar corrected
- [x] Closes #433 - hinting corrected to ensure alignment
- [x] Closes #435 - adds consistent ligature form for `=>>` `<<=` `=<<` and
  `>>=` (the infinite arrows still work with addition of more equals)
- [x] Closes #443 - ligature now ignores (*) scenario
- [x] Closes #454 - adds ignore to prevent equal_equal ligature from showing up
- [x] Closes #467 - Not specifically sure of the problem here, but suspect that
  it will be fixed with this - update.
- [x] Closes #477 - fixed
- [x] Closes #478 - fixed
- [x] Closes #479 - fixed
- [x] Closes #480 - fixed
- [x] Closes #481 - JetBrains enumerates fonts weird. I've modified the
  internal naming so that it will register Cascadia Code correctly. Also
  aligned postscript naming with Google's recommendation, so will show up as
  "Regular" instead of "Roman". Still works in Word!


Other Cascadia Code fixes:
- General improvement of weight balancing
- Weight of lowercase rounds reduced in the Bold weight in Cascadia Code.
- Weight of Capital stems increased in Extralight weight in Cascadia Code. 
- Tweaked weight of ogonek in ExtraLight.
- Added a localized form for ij and IJ should a user chose to use those
  codepoints and want an accented version.
- Split fraction bar at heavier weights to improve clarity of fractions.
- Adjusted standard box drawing characters to align with GDI metrics, and added
  a complete set of DWrite-specific ones that align with sTypo (using `rclt`).
- Ironed out some tiny inconsistencies in the <$ $> <$> ligatures which I'm
  sure no one will ever notice. 
- Fixed centering of braces and some hyphens.
- Fixed inconsistency between semicolon/colon and period weight in bold. Also
  fixed slight differences in hyphen-like glyphs in bold. You're as surprised
  as I am. 
- Increased weight of underscore in bold.
- Adjusted weighting of Ɫ.
- Changed design of commaaccent, commaaccentmod commaturnedabove and commaabove
  to be more distinguishable (following design of quotes).
- Increased height of βδθλ to align with the ascender height. They were too low
  before. 
- Fixed descents of various greek lowercase glyphs that were inconsistent. 
- Modified ξ weighting. 
- Felt ligated, might edit later.
- Tweaked ªºⁿʷʸᶿᶻ⁰¹²³⁴⁵⁶⁷⁸⁹ in imperceptable ways. 
- Corrected some additional interpolation bugs

I do enjoy giving Dustin presents.
This was referenced Sep 18, 2023
Closed
Open
@msftrncs
Copy link

Note that the problem reported here is actually both directions, (* and *), both pretty common in C/C++ code. It would appear that maybe only the *) case was fixed.

@Badaxis
Copy link

Badaxis commented Jan 26, 2024

I know this has been closed but the problem is still here with *). I'm doing pointer casting and the colorization is wrong.
image

@Badaxis Badaxis mentioned this issue Jan 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cascadia Code Upright bugfixes aaronbell/cascadia-code
7 participants
@DHowett @Nahor @ExE-Boss @aaronbell @msftrncs @Badaxis @vosaica