Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced Hypen (-) with Dash (–) to maintain symmetric view #385

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Replaced Hypen (-) with Dash (–) to maintain symmetric view #385

merged 2 commits into from
Jun 18, 2021

Conversation

sayedarifuddin
Copy link
Contributor

Summary of the Pull Request

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Requires FONTLOG.txt to be updated
  • Requires /images/cascadia-code.png and/or /images/cascadia-code-characters.png to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Before (if applicable) and After Images of the Character(s)

Validation Steps Performed

@aaronbell aaronbell merged commit e9aa335 into microsoft:main Jun 18, 2021
aaronbell added a commit to aaronbell/cascadia-code that referenced this pull request Jun 21, 2021
@aaronbell
Squashed commit of the following:
1263a52 
commit e9aa335
Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com>
Date:   Sat Jun 19 00:42:28 2021 +0600

    Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385)

    Co-authored-by: Aaron <aaronbell@users.noreply.github.com>

commit fb0bce6
Author: Aaron <aaronbell@users.noreply.github.com>
Date:   Fri Jun 18 10:37:03 2021 -0700

    Add Hebrew and Arabic; rework Italic (microsoft#511)

    Major update!

    This update includes the brand new Arabic and Hebrew language coverage,
    along with a variety of bug fixes to the upright and italic fonts. There
    has also been a major overhaul of the Cascadia Code Italic lowercase to
    make the forms align better with our vision for the font. Enjoy :).

    Supersedes microsoft#491

    Cascadia Code
    * [x] Closes microsoft#84 - Arabic language support added!
    * [x] Closes microsoft#465 - Hebrew language support added!
    * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
      ignored in propagateAnchors

    Cascadia Code Italic
    * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
    * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
    * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
      clarity. All ligature forms adjusted.

    Both
    * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

    - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
      Arabic features PDF] for the exciting new Arabic ligature
      functionality used in Cascadia Code that gives the font greatly
      improved readability and feel more more akin to a text typeface. Don't
      want all that? Don't worry, Cascadia Mono will house a normal version
      of Arabic.

    - Hebrew support added (design by Liron Lavi Turkenich)
    - Fixing a bug in the ccmp feature file and added ccmp to the feature
      set in the build script.
    - Deleting the (unused) liga feature file
    - Vika has reviewed and improved some forms in Cascadia Code upright.
    - /f, /l, /s, /r (and related forms) have been updated to follow more
      'generic' forms. Previous versions have been moved to ss01 / salt OT
      features.

    - Changed design of `ƒ` in upright to align better with the standard
      `f`. In the italic, the `ƒ` has been changed to follow the cursive
      version. When `ss01` is applied, the design of the `f` and `ƒ` are
      swapped, and if the `locl` EWE language setting is applied, the 'f'
      swaps for a straight descender version (with cursive `ƒ`).
      Complicated, but achieves supporting everything.

    - Entry and exit strokes across the italic lowercase have been rounded
      to better achieve the fun / playful design language that we intended
      for the italic. Other skeletons have been modified as necessary.
      Cyrillic has also been updated for better consistency with the new
      design.

    - Greek lowercase has been updated per feedback from Gerry Leonidas to
      be more cohesive (No longer a mix between a Monday and Friday font.
      All Friday, all the time)

    ## Validation Steps Performed
    All updated reviewed, hinted, and reviewed again :)

    [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell added a commit to aaronbell/cascadia-code that referenced this pull request Jun 23, 2021
@aaronbell
Squashed commit of the following:
0f484c6 
commit e9aa335
Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com>
Date:   Sat Jun 19 00:42:28 2021 +0600

    Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385)

    Co-authored-by: Aaron <aaronbell@users.noreply.github.com>

commit fb0bce6
Author: Aaron <aaronbell@users.noreply.github.com>
Date:   Fri Jun 18 10:37:03 2021 -0700

    Add Hebrew and Arabic; rework Italic (microsoft#511)

    Major update!

    This update includes the brand new Arabic and Hebrew language coverage,
    along with a variety of bug fixes to the upright and italic fonts. There
    has also been a major overhaul of the Cascadia Code Italic lowercase to
    make the forms align better with our vision for the font. Enjoy :).

    Supersedes microsoft#491

    Cascadia Code
    * [x] Closes microsoft#84 - Arabic language support added!
    * [x] Closes microsoft#465 - Hebrew language support added!
    * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
      ignored in propagateAnchors

    Cascadia Code Italic
    * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
    * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
    * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
      clarity. All ligature forms adjusted.

    Both
    * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

    - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
      Arabic features PDF] for the exciting new Arabic ligature
      functionality used in Cascadia Code that gives the font greatly
      improved readability and feel more more akin to a text typeface. Don't
      want all that? Don't worry, Cascadia Mono will house a normal version
      of Arabic.

    - Hebrew support added (design by Liron Lavi Turkenich)
    - Fixing a bug in the ccmp feature file and added ccmp to the feature
      set in the build script.
    - Deleting the (unused) liga feature file
    - Vika has reviewed and improved some forms in Cascadia Code upright.
    - /f, /l, /s, /r (and related forms) have been updated to follow more
      'generic' forms. Previous versions have been moved to ss01 / salt OT
      features.

    - Changed design of `ƒ` in upright to align better with the standard
      `f`. In the italic, the `ƒ` has been changed to follow the cursive
      version. When `ss01` is applied, the design of the `f` and `ƒ` are
      swapped, and if the `locl` EWE language setting is applied, the 'f'
      swaps for a straight descender version (with cursive `ƒ`).
      Complicated, but achieves supporting everything.

    - Entry and exit strokes across the italic lowercase have been rounded
      to better achieve the fun / playful design language that we intended
      for the italic. Other skeletons have been modified as necessary.
      Cyrillic has also been updated for better consistency with the new
      design.

    - Greek lowercase has been updated per feedback from Gerry Leonidas to
      be more cohesive (No longer a mix between a Monday and Friday font.
      All Friday, all the time)

    ## Validation Steps Performed
    All updated reviewed, hinted, and reviewed again :)

    [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IDisposable IDisposable IDisposable approved these changes

@pyrofirezer0 pyrofirezer0 pyrofirezer0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sayedarifuddin @IDisposable @pyrofirezer0 @aaronbell