Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y bug #59

Merged
merged 5 commits into from
Mar 3, 2023
Merged

A11y bug #59

merged 5 commits into from
Mar 3, 2023

Conversation

Harikarall
Copy link
Contributor

Added a function so that keyboard focus does not move to the title of the product catalog page and narrator announces show more button contents without announcing product catalog. Updated aria-expanded to dynamic update.

Testing Details
1.Verified and checked the changes to reflect in the UI locally
2.Verified all unit tests snapshots have passed locally
3.Verified to check if there are no additional issues due to the Change by running Accessibility insights locally.

package.json Show resolved Hide resolved
src/contactCard/Summary.tsx Show resolved Hide resolved
src/contactCard/Summary.tsx Outdated Show resolved Hide resolved
src/contactCard/Summary.tsx Show resolved Hide resolved
@PeterYangIO PeterYangIO merged commit 7b97c13 into master Mar 3, 2023
@PeterYangIO PeterYangIO deleted the A11yBug branch March 3, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants