Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "startDebugging" request for subprocesses #1074

Closed
rchiodo opened this issue Oct 3, 2022 · 2 comments
Closed

Use "startDebugging" request for subprocesses #1074

rchiodo opened this issue Oct 3, 2022 · 2 comments
Assignees
@int19h
Labels
enhancement New feature or request

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Oct 3, 2022 •
edited by int19h
Loading

See:
https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_73.md#new-startdebugging-reverse-request
@rchiodo rchiodo added the enhancement New feature or request label Oct 3, 2022
@int19h
Copy link
Contributor

int19h commented Oct 3, 2022

For backwards compatibility, we'll need to fall back to debugpyAttach if supportsStartDebuggingRequest is false.

@karthiknadig, is there anything special that vscode-python does about debugpyAttach request, other than forwarding it to VSCode to initiate a new session, like any attribute rewrites?

@karthiknadig karthiknadig mentioned this issue Oct 10, 2022
Closed
@fabioz fabioz mentioned this issue Oct 28, 2022
Closed
@int19h int19h mentioned this issue Nov 9, 2022
Closed
@int19h int19h self-assigned this Feb 1, 2023
@int19h int19h changed the title Support reverse request in DAP Use "startDebugging" request for subprocesses Feb 7, 2023
int19h pushed a commit to int19h/debugpy that referenced this issue Feb 7, 2023
Fix microsoft#1074: Use "startDebugging" request for subprocesses
8b7645a 
Use the request if client advertises the "supportsStartDebuggingRequest" capability.
@int19h
Copy link
Contributor

int19h commented Feb 7, 2023

Some blockers and limitations on VSCode side:

microsoft/vscode#173654
microsoft/vscode#173655

int19h pushed a commit to int19h/debugpy that referenced this issue Feb 7, 2023
Fix microsoft#1074: Use "startDebugging" request for subprocesses
f61d794 
Use the request if client advertises the "supportsStartDebuggingRequest" capability.
int19h pushed a commit to int19h/debugpy that referenced this issue Feb 7, 2023
Fix microsoft#1074: Use "startDebugging" request for subprocesses
dbda19f 
Use the request if client advertises the "supportsStartDebuggingRequest" capability.
@int19h int19h closed this as completed in e9dc3e8 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@int19h int19h

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@int19h @rchiodo