Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate gRPC service registration from NewGrpcExecutor #26

Merged
merged 5 commits into from
Jul 13, 2023
Merged

Separate gRPC service registration from NewGrpcExecutor #26

merged 5 commits into from
Jul 13, 2023

Conversation

ItalyPaleAle
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle commented Jul 13, 2023 •
edited
Loading

This change allows creating a NewGrpcExecutor and separately register it into a gRPC server. This makes it possible to use the same executor with multiple gRPC servers.

Part of the fix for dapr/dapr#6648

@ItalyPaleAle ItalyPaleAle changed the title WIP: Separate gRPC service registration from NewGrpcExecutor Separate gRPC service registration from NewGrpcExecutor Jul 13, 2023
@ItalyPaleAle ItalyPaleAle mentioned this pull request Jul 13, 2023
Merged
cgillum
cgillum approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice design, and I very much appreciate the other small quality improvements you added along the way. Thanks!

@cgillum cgillum merged commit d7723da into microsoft:main Jul 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItalyPaleAle @cgillum