Integration tests use DevOps MI for Cosmos #4369
Merged
+157
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankowitz
changed the title
brendankowitz
force-pushed
the
personal/bkowitz/cosmos-mi-arm
branch
2 times, most recently
from
dec47bc
to
db42bec
Compare
brendankowitz
force-pushed
the
personal/bkowitz/cosmos-mi-int-tests
branch
from
cf84ece
to
925dbc4
Compare
brendankowitz
commented
Sep 17, 2024
brendankowitz
force-pushed
the
personal/bkowitz/cosmos-mi-int-tests
branch
2 times, most recently
from
06bb04e
to
9743303
Compare
brendankowitz
force-pushed
the
personal/bkowitz/cosmos-mi-int-tests
branch
from
9743303
to
f24ee36
Compare
brendankowitz
added
Enhancement-Test
brendankowitz
changed the title
mikaelweave
approved these changes
Sep 23, 2024
| @@ -692,20 +693,6 @@ | |||
| "[resourceId('Microsoft.DocumentDb/databaseAccounts', variables('serviceName'))]" | |||
| ] | |||
| }, | |||
| { | |||
| "condition": "[equals(parameters('solutionType'),'FhirServerCosmosDB')]", | |||
| "type": "Microsoft.KeyVault/vaults/secrets", | |||
There was a problem hiding this comment.
NIT: Do we even need the keyvault anymore? Could be a new story.
There was a problem hiding this comment.
SQL is still using the keyvault too, it is at least consisntent. Might merge this first so I can mitigate having localauth enabled
| @@ -39,16 +40,19 @@ public FhirCosmosClientInitializer( | |||
| ICosmosClientTestProvider testProvider, | |||
| Func<IEnumerable<RequestHandler>> requestHandlerFactory, | |||
| RetryExceptionPolicyFactory retryExceptionPolicyFactory, | |||
| Lazy<TokenCredential> tokenCredential, | |||
There was a problem hiding this comment.
Does this need to be Lazy? I think the implementations of TokenCredential already are lazy and the wait is when the token is requested.
There was a problem hiding this comment.
...good point, I was thinking to not resolve it at all if the key is still being used. Not sure I have a strong opinion on this
| Key = Environment.GetEnvironmentVariable("CosmosDb:Key") ?? CosmosDbLocalEmulator.Key, | ||
| DatabaseId = Environment.GetEnvironmentVariable("CosmosDb:DatabaseId") ?? "FhirTests", | ||
| Host = Environment.GetEnvironmentVariable("CosmosDb__Host") ?? CosmosDbLocalEmulator.Host, | ||
| Key = Environment.GetEnvironmentVariable("CosmosDb__Key") ?? CosmosDbLocalEmulator.Key, |
There was a problem hiding this comment.
NIT: Should key be null if we are using MI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR and CI pipelines should use MI for Integration Tests
Related issues
Addresses AB#126615
Testing
Existing tests should pass, using new MI credentials for Cosmos
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)