Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes clean-storage-accounts.yml #4644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes clean-storage-accounts.yml #4644

wants to merge 1 commit into from
+4 −2

Conversation

brendankowitz
Copy link
Member

@brendankowitz brendankowitz commented Sep 24, 2024 •
edited by azure-boards bot
Loading

Description

Updates clean-storage-accounts.yml to use connected principal over key based access.

Related issues

Addresses AB#126690

Testing

Tested by temporarily adding to the task to the PR pipeline:
image

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

None

@brendankowitz brendankowitz force-pushed the personal/bkowitz/fix-delete-storage branch 2 times, most recently from 8d1d1df to a40e628 Compare September 24, 2024 23:35
@brendankowitz brendankowitz changed the title Personal/bkowitz/fix delete storage Fixes clean-storage-accounts.yml Sep 24, 2024
@brendankowitz brendankowitz marked this pull request as ready for review September 24, 2024 23:36
@brendankowitz brendankowitz requested a review from a team as a code owner September 24, 2024 23:36
@brendankowitz brendankowitz added Build Open source This change is only relevant to the OSS code or release. labels Sep 24, 2024
@brendankowitz brendankowitz added this to the S150 milestone Sep 24, 2024
@brendankowitz brendankowitz enabled auto-merge (squash) September 24, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Open source This change is only relevant to the OSS code or release.
Projects
None yet
Milestone
S150
Development

Successfully merging this pull request may close these issues.
1 participant
@brendankowitz