-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple apk architectures + upload mapping #378
base: master
Are you sure you want to change the base?
Conversation
This part I have not extensively tested like I have over in main.ts. The general take away is that we have a scenario where we have multiple apks, each apk needs to have an attached mapping file when uploading. Would be nice if the plugin integrated this.
@wyguy321 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Does this PR support adding mapping.txt file when we have chosen to upload both apks and app bundles at the same time? |
Hi - Yes. Basically, I got an error locally testing "MultiApkAab", kept throwing an error about not supplying .aab. So I brute forced my way around it in my own version to create "multi apks". But after re-reading the code in inputsHelper.ts, specifically lines 95-103, it should theoretically work with just supplying "MultiApkAab" with only apk files right?
With this understanding in mind.. only lines 69 and 164-174 need to be changed over in https://github.com/microsoft/google-play-vsts-extension/blob/master/Tasks/GooglePlayReleaseV4/main.ts
I can create a new PR with these changes only to /main.ts if you think that is easier. |
Task name: Support for multi apk support + mapping.
Description: We have a situation where we want to upload multiple apks and attach their associated mapping file to the apks.
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist: