Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subscription in SigTransformerSchema to cover that vhd is in other sub #3348

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add subscription in SigTransformerSchema to cover that vhd is in other sub #3348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lisa/sut_orchestrator/azure/transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,9 @@ class SigTransformerSchema(schema.Transformer):
# raw vhd URL, it can be the blob under the same subscription of SIG
# or SASURL
vhd: str = field(default="", metadata=field_metadata(required=True))
# If vhd is a blob fullpath and is in another subscription,
# the subscription should be specified
subscription: str = ""
# if not specify gallery_resource_group_name, use shared resource group name
gallery_resource_group_name: str = field(default=AZURE_SHARED_RG_NAME)
# if not specified, will use the first location of gallery image
Expand Down Expand Up @@ -508,7 +511,7 @@ def _internal_run(self) -> Dict[str, Any]:
if not runbook.gallery_location:
runbook.gallery_location = image_location
vhd_path = get_deployable_vhd_path(
platform, runbook.vhd, image_location, self._log
platform, runbook.vhd, image_location, self._log, runbook.subscription
)
vhd_details = get_vhd_details(platform, vhd_path)
check_blob_exist(
Expand Down
Loading