Moved user password support to execute_async() for running test case #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulli2017
force-pushed
the
paull/process-async
branch
from
c1cd82c
to
0936c92
Compare
|
Please remove test cases changes from this PR. They are in another PR. |
squirrelsc
reviewed
Aug 15, 2024
paulli2017
force-pushed
the
paull/process-async
branch
3 times, most recently
from
2f0ab3a
to
4809cbf
Compare
squirrelsc
reviewed
Aug 16, 2024
paulli2017
force-pushed
the
paull/process-async
branch
from
4809cbf
to
1d4f6cc
Compare
squirrelsc
approved these changes
Aug 16, 2024
paulli2017
force-pushed
the
paull/process-async
branch
from
1d4f6cc
to
78618d5
Compare
|
@LiliDeng LGTM |
LiliDeng
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current run of test cases has two methods: 1. call node.execute.async() and then process.wait_result() 2. call node.execute.async and then pgrep.wait_process(). Both works ok if the test run doesn't need username and password while running on target, otherwise the second method will fail due to the missing username and password. The first method works because it has username and password process in process.wait_result() call. This change list is to move the username and password process in process.wait_result() to node.execute.async() so that both methods of running a test case will work. And this change will not cause behavior changes for the first method, which helps avoid the regression issue.