-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TabView themes aren't accessible #1901
Comments
@stmoy, can you please follow up on this one ? |
Good news: The WinUI TabView has better contrast than Edge There are fundamental constraints in place within the color ramp that make it difficult to get enough visibility between selected and unselected tabs using color alone. It's possible that we'll need to use another affordance to help increase the visibility (like text weight, shape, etc.) instead of color contrast. I'm following up internally. For now lets "push pause" on this issue. |
I think it would already be much better if the selected tab is brighter than the unselected one in dark mode like it is done in edge. Its weird that the foreground is supposed to be darker than the background. Also the tabbar could be made acrylic like the old edge. |
Eventually all the Light and Dark theme resources should be reviewed, and Accessibility contrast-ratios should be adhered to. #920 For now, can someone from the design team audit it, or checks done to ensure the design specs are being matched in the Xaml Resources? |
It may be worth considering adding a Selection Indicator of some kind. Strict adherence to contrast ratios would lead to colours that I think many would complain about. High contrast themes will of course handle these controls in a responsible way. I suspect the Edge team will lead the way with the design, but WinUI can deviate where needed, and the Windows Terminal team may have some thoughts. |
Having a selection indicator is also an interesting idea, though it's a bit uncommon for this kind of control I would say. Regarding Edge, the way it behaves on my machine is the following (not sure if this is currently the default or not): With having a non gray background, we would easily be able to meet contrast ratios, though that would look even worse in a lot of scenarios than using a darker/lighter gray. |
Hey whoever triages winui these days - @gabbybilka maybe? I'm pretty sure this is super stale. Admittedly, Not sure how this held up with the Mica/MicaAlt changes. This may need to be re-framed in that context. Or hey maybe the default TabView themes are accessible these days? |
Describe the bug
Due to the lack of contrast, it's difficult to determine which tab is the active tab. Additionally, the color contrast ratios between the active tab and the tab bar aren't great enough to meet accessibility needs.
Minimum requirement for accessibility is 3:1 ratio.
Steps to reproduce the bug
Expected behavior
A resulting ratio of 3:1 or higher.
Screenshots
Light theme has a color contrast ratio of 1.605:1
Dark theme has a color contrast ratio of 1.662:1
Version Info
NuGet package version:
Additional context
The text was updated successfully, but these errors were encountered: