-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TabView's New Tab Button color contrast ratio inaccessible (Light Theme) #2353
Comments
@carlos-zamora Both TabView + and the splitbutton have this issue ? @chigy as FYI. |
Yeah. I assume this is different from #1901 because it's a different resource dictionary, but if not, feel free to close it. This is being tracked in the Terminal repo here (microsoft/terminal#5392) and was submitted by the accessibility testers. |
@carlos-zamora , do you have screenshot of the offending UI? |
Yes. They should be visible in the issue description above. Windows Terminal is on the left side, and Accessibility Insights is on the right detecting the issue. |
@carlos-zamora , oops, I see it now. I wasn't clear what I was looking at. :) @stmoy , is this issue with TabView or the way those resources are used within Terminal? |
Huh. I just noticed that we do this:
Overriding the SplitButton's resources to match the tab view's button styles. So this might actually be an issue with the TabView resources. And a duplicate of #1901. Sorry! |
Good question. I was under the impression that the SplitButton was custom for Terminal (as the regular ol' TabView doesn't have one built in) - but I think that it cannot be fixed independently of the TabView fix since it has a transparent background. I don't think it's actually a dupe of #1901 as I'm guessing there will need to be some custom work here, but I think the former must be solved before this. |
@carlos-zamora , what is this measuring? |
Oh sorry! I've been running around a bit today. The above ratios are measuring the color contrast of the New Tab Button that is included by default in a TabView. Color 1 is the color of the '+' (foreground) , and Color 2 is the background. In Terminal, we suppress the New Tab button and replace it with a SplitButton that matches the styling (same foreground and background color). So, it turns out, I was incorrect in what I first said reporting this issue. The problem isn't the SplitButton's color contrast, but rather the New Tab button's that is shipped in the TabView. I'll update the issue title and description appropriately. Sorry about the confusion. |
@ranjeshj - yes, but it's more than that. Several parts of TabView (background/foreground, buttons, text) don't meet the updated contrast ratio guidance. #1901 tracks taking a holistic pass across TabView to bring it up to compliance. We should probably close this one as a dupe of #1901 if @carlos-zamora believes that updating the defaults will fix this case. |
Yeah. Feel free to mark this as a duplicate of that one :) |
ok. Lets track this as part of the other issue then. Thanks |
Describe the bug
The New Tab Button for the TabView does not meet a 3:1 color contrast ratio.
Steps to reproduce the bug
This can be seen in Windows Terminal's TabRowControl.xaml, where we replace the NewTabButton with a SplitButton matching the styling of the TabView's NewTabButton.
More easily, this can be seen/tested in the Xaml Controls Gallery page introducing the TabView.
Steps to reproduce the behavior:
Expected behavior
It meets the 3:1 ratio
Screenshots
Light Theme (fails)
Dark Theme (passes)
Version Info
NuGet package version:
The text was updated successfully, but these errors were encountered: