Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression, fix proposed] NumberBox content overlaps with increment button in win11 styles #5983

Closed
eugenegff opened this issue Sep 27, 2021 · 5 comments · Fixed by #5985
Closed
Labels
area-NumberBox NumberBox Control team-Controls Issue for the Controls team

Comments

@eugenegff
Copy link
Contributor

eugenegff commented Sep 27, 2021

Describe the bug

NumberBox content overlaps with increment button in win11 styles on WinUI 2.7

Steps to reproduce the bug

  1. New Blank C++/CX project, add NumberBox to MainPage.xaml
    <StackPanel>
        <muxc:NumberBox HorizontalAlignment="Left" SpinButtonPlacementMode="Inline" Value="1234567"/>
    </StackPanel>
  1. Run

Note, that text and first spin button are overlapped, despite unlimited control width.

image

Note, that there are no such problem in ControlsResourcesVersion="Version1" mode, i.e. it is regression

image

XamlControlsGallery

image

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Sep 27, 2021
@eugenegff eugenegff changed the title NumberBox content overlaps with increment button in win11 styles [Regression, fix proposed] NumberBox content overlaps with increment button in win11 styles Sep 27, 2021
@eugenegff eugenegff changed the title [Regression, fix proposed] NumberBox content overlaps with increment button in win11 styles [Regression] NumberBox content overlaps with increment button in win11 styles Sep 27, 2021
@ghost ghost added the working on it label Sep 27, 2021
@eugenegff eugenegff changed the title [Regression] NumberBox content overlaps with increment button in win11 styles [Regression, fix proposed] NumberBox content overlaps with increment button in win11 styles Sep 27, 2021
@eugenegff
Copy link
Contributor Author

In modern win11 like styles inner TextBox has Grid.ColumnSpan=3 to supply external border. Space for inline spin buttons is reserved inside it by setting DeleteButton.Margin, and this approach failed when DeleteButton.Visibility == Collapsed, i.e. when NumberBox is not focused.

@StephenLPeters StephenLPeters added area-NumberBox NumberBox Control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Sep 27, 2021
@ghost ghost removed the working on it label Oct 7, 2021
@ghost
Copy link

ghost commented Apr 14, 2022

🎉This issue was addressed in #5985, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 13, 2022

🎉This issue was addressed in #5985, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉This issue was addressed in #5985, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉This issue was addressed in #5985, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NumberBox NumberBox Control team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants