Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to WinUI 2.8 (was: History size overlaps with widget controls) #13495

Closed
1 task
Tracked by #12400
elsaco opened this issue Jul 13, 2022 · 3 comments · Fixed by #15078
Closed
1 task
Tracked by #12400

Update to WinUI 2.8 (was: History size overlaps with widget controls) #13495

elsaco opened this issue Jul 13, 2022 · 3 comments · Fixed by #15078
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Milestone
Terminal v1.18

Comments

@elsaco
Copy link

elsaco commented Jul 13, 2022 •
edited by zadjii-msft
Loading

Windows Terminal version

1.15.1863.0

Windows build number

10.0.22000.778

Other Software

No response

Steps to reproduce

Enter a large history size, INT_MAX used for testing

Expected Behavior

No overlapping

Actual Behavior

max_history_size

maintainer note

Also:
@elsaco elsaco added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 13, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 13, 2022
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Settings UI Anything specific to the SUI labels Jul 14, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jul 14, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 14, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 14, 2022
Open
12 tasks
@serd2011
Copy link
Contributor

isn't this it microsoft/microsoft-ui-xaml#5983 ?

@zadjii-msft
Copy link
Member

Sure looks like it to me, thanks! We haven't had an opportunity to move to WinUI 2.8 yet, but I'm gonna tentatively use this to track upgrading. We also need to do this to fix the crashes associated with #12413 in downlevel OS versions.

@zadjii-msft zadjii-msft added Tracking-External This bug isn't resolved, but it's following an external workitem. and removed Help Wanted We encourage anyone to jump in on these. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 18, 2022
@zadjii-msft zadjii-msft changed the title History size overlaps with widget controls Update to WinUI 2.8 (was: History size overlaps with widget controls) Jul 18, 2022
@zadjii-msft zadjii-msft modified the milestones: Backlog, Terminal v1.16 Jul 18, 2022
This was referenced Aug 2, 2022
Open
Closed
@ghost ghost added the In-PR This issue has a related PR label Aug 2, 2022
@zadjii-msft
Copy link
Member

Taking this out of 1.16, cause it seems like there's a lot of issues with 2.8 and we don't have the runway to sort them all out. The important bit, the #12413 crash, we're gonna fix with a minor hotfix to 2.7.

@zadjii-msft zadjii-msft modified the milestones: Terminal v1.16, Backlog Aug 16, 2022
@ghost ghost removed the In-PR This issue has a related PR label Aug 16, 2022
@zadjii-msft zadjii-msft mentioned this issue Dec 12, 2022
Closed
@ianjoneill ianjoneill mentioned this issue Dec 15, 2022
Closed
@zadjii-msft zadjii-msft modified the milestones: Backlog, Terminal v1.18 Jan 11, 2023
This was referenced Apr 3, 2023
Merged
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Apr 3, 2023
DHowett added a commit that referenced this issue Apr 3, 2023
@zadjii-msft @DHowett
Upgrade to MUX 2.8 (#15078)
17cf44f 
Updates the Terminal to Microsoft.UI.Xaml v2.8. 

* MUX 2.8 adds a dependency on WebView2, so we need to include parts of it too.
* See microsoft/microsoft-ui-xaml#7574 for why
we're adding the `.props`
* The TabView thing: 
> tl;dr: In >=MUX 2.7, we were updating our tab colors by doing a
"Visual State Dance", as I called it. We'd manually change the
`TabViewItem`'s VisualState to one that it wasn't in, then change it
back to the one it should be in. This seemingly re-applied the new
values of the brushes. However in 2.8, this seemingly didn't work
anymore!
  > 
  > So instead, we do a "Theme Dance", like so:
  > ```c++
  >   const auto& reqTheme = TabViewItem().RequestedTheme();
  >   TabViewItem().RequestedTheme(ElementTheme::Light);
  >   TabViewItem().RequestedTheme(ElementTheme::Dark);
  >   TabViewItem().RequestedTheme(reqTheme);
  >   ```
> This causes the `ThemeResource`s to be re-evaluated to the new values.
> We never got to the root cause of why this seems different in 2.8. It
literally makes no sense.
Closes #13495

Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Milestone
Terminal v1.18
Development

Successfully merging a pull request may close this issue.

Upgrade to MUX 2.8 microsoft/terminal
Update MUX to 2.8 microsoft/terminal
3 participants
@elsaco @zadjii-msft @serd2011