Ensure correct .props and .targets order in nuget package #7574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jevansaks
reviewed
Aug 8, 2022
asklar
approved these changes
Aug 8, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
asklar
approved these changes
Aug 10, 2022
|
🎉 Handy links: |
ranjeshj
added
area-NugetPackage
zadjii-msft
added a commit
to microsoft/terminal
that referenced
this pull request
Apr 3, 2023
1 task
DHowett
added a commit
to microsoft/terminal
that referenced
this pull request
Apr 3, 2023
Updates the Terminal to Microsoft.UI.Xaml v2.8. * MUX 2.8 adds a dependency on WebView2, so we need to include parts of it too. * See microsoft/microsoft-ui-xaml#7574 for why we're adding the `.props` * The TabView thing: > tl;dr: In >=MUX 2.7, we were updating our tab colors by doing a "Visual State Dance", as I called it. We'd manually change the `TabViewItem`'s VisualState to one that it wasn't in, then change it back to the one it should be in. This seemingly re-applied the new values of the brushes. However in 2.8, this seemingly didn't work anymore! > > So instead, we do a "Theme Dance", like so: > ```c++ > const auto& reqTheme = TabViewItem().RequestedTheme(); > TabViewItem().RequestedTheme(ElementTheme::Light); > TabViewItem().RequestedTheme(ElementTheme::Dark); > TabViewItem().RequestedTheme(reqTheme); > ``` > This causes the `ThemeResource`s to be re-evaluated to the new values. > We never got to the root cause of why this seems different in 2.8. It literally makes no sense. Closes #13495 Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where WinUI 2.8 couldn't be used in XAML islands apps.
Description
When you add a nuget package reference, VS will add imports for the package’s props and targets. Props go at the top, targets at the bottom. WinUI didn't have a props file in the right location in the package (in build\native), only targets. The WinUI targets import a props file from a directory above. This means that it’s possible for WebView2’s targets to be imported before WinUI's targets (and therefore the WinUI props), rendering the project unbuildable. This change moves the props file to the build/native directory, and removes the unnecessary import.
http://task.ms/40798730