UI nits from WinUI Controlsv2 #12400
Labels
Area-User Interface
Issues pertaining to the user interface of the Console or Terminal
Issue-Scenario
Product-Terminal
The new Windows Terminal.
Milestone
Comments
ghost
added
Needs-Triage
zadjii-msft
added
Area-User Interface
zadjii-msft
removed
the
Needs-Triage
This was referenced Feb 25, 2022
ghost
pushed a commit
that referenced
this issue
Mar 9, 2022
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to 12dips. This is harder for folks to hit with the mouse, and isn't consistent with the rest of the scrollbars on the platform (as much as they can be). To work around this, we have to entirely copy the template for the ScrollBar into our XAML file. We're then also re-defining ScrollBarSize here to 16, so that the new template will pick up on the new value. This is kinda a pain, and we have to be careful to be sure to ingest an updated version of the template any time we update MUX. The latest Controlsv2 version of the template can be found at: https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218 We're also planning on making this adjustable in the future (GH#9218), where we might need this anyways. ##### after, before:  ##### after overlayed on top of before  ##### comparison  * reported originally in #12395 * upstream: microsoft/microsoft-ui-xaml#6684 * closes an element of #12400
ghost
pushed a commit
that referenced
this issue
Mar 9, 2022
Again, to reflect continuing discussion with the WinUI team. A doc may have been misread - these are the colors they're proposing, which are generally a lot better. See also: #12400, #12356, #12398 
DHowett
pushed a commit
that referenced
this issue
Mar 10, 2022
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to 12dips. This is harder for folks to hit with the mouse, and isn't consistent with the rest of the scrollbars on the platform (as much as they can be). To work around this, we have to entirely copy the template for the ScrollBar into our XAML file. We're then also re-defining ScrollBarSize here to 16, so that the new template will pick up on the new value. This is kinda a pain, and we have to be careful to be sure to ingest an updated version of the template any time we update MUX. The latest Controlsv2 version of the template can be found at: https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218 We're also planning on making this adjustable in the future (GH#9218), where we might need this anyways. ##### after, before:  ##### after overlayed on top of before  ##### comparison  * reported originally in #12395 * upstream: microsoft/microsoft-ui-xaml#6684 * closes an element of #12400 (cherry picked from commit da2cf8c)
DHowett
pushed a commit
that referenced
this issue
Mar 10, 2022
Again, to reflect continuing discussion with the WinUI team. A doc may have been misread - these are the colors they're proposing, which are generally a lot better. See also: #12400, #12356, #12398  (cherry picked from commit aaa3ee7)
zadjii-msft
added a commit
that referenced
this issue
Mar 10, 2022
Again, to reflect continuing discussion with the WinUI team. A doc may have been misread - these are the colors they're proposing, which are generally a lot better. See also: #12400, #12356, #12398 
zadjii-msft
added a commit
that referenced
this issue
Mar 10, 2022
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to 12dips. This is harder for folks to hit with the mouse, and isn't consistent with the rest of the scrollbars on the platform (as much as they can be). To work around this, we have to entirely copy the template for the ScrollBar into our XAML file. We're then also re-defining ScrollBarSize here to 16, so that the new template will pick up on the new value. This is kinda a pain, and we have to be careful to be sure to ingest an updated version of the template any time we update MUX. The latest Controlsv2 version of the template can be found at: https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218 We're also planning on making this adjustable in the future (GH#9218), where we might need this anyways. ##### after, before:  ##### after overlayed on top of before  ##### comparison  * reported originally in #12395 * upstream: microsoft/microsoft-ui-xaml#6684 * closes an element of #12400
|
Now the release version is suffering. Black seems a bad choice for the background of the tab portion of the window. The icon for opening the dropdown menu (down arrowhead?) is too small.
|
|
Unfortunately for us, those colors were chosen under official guidance from the UI folks. |
|
How about the size of the symbol on the dropdown menu's icon? It's not the same size as the symbols on the icons for new tab, minimize, maximize, and close (compare to previous UI version). It just looks like a mistake! |
|
Could the padding with the settings UI be increased? On larger window sizes it begins to look really cramped with almost no space between the title and content, and also seems to be inconsistent with other WinUI apps. Current Clock app XAML Controls Gallery Store The WinUI design toolkit generally uses 56x44px padding across NavigationView: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Terminal 1.13 we updated our version of WinUI to closer align with the Windows 11 styles. (in technical terms, we updated to ControlsV2). This had a variety of minor visual artifacts associated with it:
Relevant PRS:
The text was updated successfully, but these errors were encountered: