Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: Scrollbar thickness is smaller in ControlsV2 #6684

Closed
zadjii-msft opened this issue Feb 7, 2022 · 1 comment
Closed

Discussion: Scrollbar thickness is smaller in ControlsV2 #6684

zadjii-msft opened this issue Feb 7, 2022 · 1 comment
Labels
area-ScrollBar area-UIDesign UI Design, styling discussion General discussion team-Controls Issue for the Controls team

Comments

@zadjii-msft
Copy link
Member

The Terminal moved to Controlsv2 with Terminal 1.13, and has received a whole plethora of feedback about the new thickness (width) of the scrollbars. The thread on our side tracking this is: microsoft/terminal#12395. Some verbatims:

The vertical scroll bar was sufficiently narrow so as to make it difficult to use. And, IIRC, someone recently asked about making it wider (I'll second that, a little late). In 1.13.10336.0 it's even narrower than it was previously. Things don't seem to be going in the right direction.

image

Windows Terminal is still an important test ground for WinUI

If that's so, I'm confident that those developers are paying close attention to feedback here.

And if feedback should be directed to them that would seem to be the job of the WindowsTerminal team (not mine).

At this point they can simply remove it, since it's 99% impossible to grab it with the mouse with sufficient reaction time to be useful.

i.imgur.com/6Gh2QIa.png

What a mockery, microsoft!

... it's 99% impossible to grab it with the mouse with sufficient reaction time to be useful.

I'll have to agree here. The new 1.13 update brings in a lot of (breaking) changes for Windows 10 users (which according to Microsoft is still supported till 2025). I never had UI problems with Preview updates before, but it is very un-Microsoft-y to neglect old-gen (here, Windows 10) users with usability stuff like this.

I personally do not consider the new scrollbars as optimal for mouse usage.

Please correct me if I'm wrong, but isn't the whole point of having a scroll bar, to facilitate mouse usage? I presume it's going to be problematic even for Windows 11 users (if the width is as narrow there as Windows 10).

We're tracking "adding a setting to control the scrollbar width" in microsoft/terminal#9218, though we don't have any immediate plans to get to that. Regardless, we've got a lot of negative community feedback already about the new scrollbar width, so I figured we should echo the sentiment upstream.
@zadjii-msft zadjii-msft added the discussion General discussion label Feb 7, 2022
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 7, 2022
This was referenced Feb 7, 2022
Open
Closed
Open
Open
@zadjii-msft zadjii-msft mentioned this issue Mar 1, 2022
Merged
@StephenLPeters StephenLPeters added area-ScrollBar area-UIDesign UI Design, styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 4, 2022
@StephenLPeters
Copy link
Contributor

@chigy FYI

ghost pushed a commit to microsoft/terminal that referenced this issue Mar 9, 2022
@zadjii-msft
Make the Scrollbar 16dips again (#12608)
da2cf8c 
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to
12dips. This is harder for folks to hit with the mouse, and isn't
consistent with the rest of the scrollbars on the platform (as much
as they can be).

To work around this, we have to entirely copy the template for the
ScrollBar into our XAML file. We're then also re-defining
ScrollBarSize here to 16, so that the new template will pick up on
the new value.

This is kinda a pain, and we have to be careful to be sure to ingest
an updated version of the template any time we update MUX. The
latest Controlsv2 version of the template can be found at:
https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218

We're also planning on making this adjustable in the future
(GH#9218), where we might need this anyways.

##### after, before:
![image](https://user-images.githubusercontent.com/18356694/156254464-1a9080f6-51ce-4619-b002-2a3c607cdf5f.png)

##### after overlayed on top of before
![image](https://user-images.githubusercontent.com/18356694/156254546-fccc3cee-12a3-4e1a-8fd7-7470f1ec93ad.png)

##### comparison
![image](https://user-images.githubusercontent.com/18356694/156257934-ec4ac840-c8ca-4fca-a848-08a32b1c55c3.png)

* reported originally in #12395
* upstream: microsoft/microsoft-ui-xaml#6684
* closes an element of #12400
DHowett pushed a commit to microsoft/terminal that referenced this issue Mar 10, 2022
@zadjii-msft @DHowett
Make the Scrollbar 16dips again (#12608)
5a5c17d 
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to
12dips. This is harder for folks to hit with the mouse, and isn't
consistent with the rest of the scrollbars on the platform (as much
as they can be).

To work around this, we have to entirely copy the template for the
ScrollBar into our XAML file. We're then also re-defining
ScrollBarSize here to 16, so that the new template will pick up on
the new value.

This is kinda a pain, and we have to be careful to be sure to ingest
an updated version of the template any time we update MUX. The
latest Controlsv2 version of the template can be found at:
https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218

We're also planning on making this adjustable in the future
(GH#9218), where we might need this anyways.

##### after, before:
![image](https://user-images.githubusercontent.com/18356694/156254464-1a9080f6-51ce-4619-b002-2a3c607cdf5f.png)

##### after overlayed on top of before
![image](https://user-images.githubusercontent.com/18356694/156254546-fccc3cee-12a3-4e1a-8fd7-7470f1ec93ad.png)

##### comparison
![image](https://user-images.githubusercontent.com/18356694/156257934-ec4ac840-c8ca-4fca-a848-08a32b1c55c3.png)

* reported originally in #12395
* upstream: microsoft/microsoft-ui-xaml#6684
* closes an element of #12400

(cherry picked from commit da2cf8c)
zadjii-msft added a commit to microsoft/terminal that referenced this issue Mar 10, 2022
@zadjii-msft
Make the Scrollbar 16dips again (#12608)
208dccd 
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to
12dips. This is harder for folks to hit with the mouse, and isn't
consistent with the rest of the scrollbars on the platform (as much
as they can be).

To work around this, we have to entirely copy the template for the
ScrollBar into our XAML file. We're then also re-defining
ScrollBarSize here to 16, so that the new template will pick up on
the new value.

This is kinda a pain, and we have to be careful to be sure to ingest
an updated version of the template any time we update MUX. The
latest Controlsv2 version of the template can be found at:
https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218

We're also planning on making this adjustable in the future
(GH#9218), where we might need this anyways.

##### after, before:
![image](https://user-images.githubusercontent.com/18356694/156254464-1a9080f6-51ce-4619-b002-2a3c607cdf5f.png)

##### after overlayed on top of before
![image](https://user-images.githubusercontent.com/18356694/156254546-fccc3cee-12a3-4e1a-8fd7-7470f1ec93ad.png)

##### comparison
![image](https://user-images.githubusercontent.com/18356694/156257934-ec4ac840-c8ca-4fca-a848-08a32b1c55c3.png)

* reported originally in #12395
* upstream: microsoft/microsoft-ui-xaml#6684
* closes an element of #12400
@microsoft microsoft locked and limited conversation to collaborators Jul 22, 2022
@ranjeshj ranjeshj converted this issue into discussion #7422 Jul 22, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
area-ScrollBar area-UIDesign UI Design, styling discussion General discussion team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StephenLPeters @zadjii-msft