Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabView contrast is worse in ControlsV2 #6685

Open
1 task done
zadjii-msft opened this issue Feb 7, 2022 · 2 comments
Open
1 task done

TabView contrast is worse in ControlsV2 #6685

zadjii-msft opened this issue Feb 7, 2022 · 2 comments
Labels
area-TabView area-UIDesign UI Design, styling bug Something isn't working team-Controls Issue for the Controls team

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Feb 7, 2022

Describe the bug

Filed on behalf of microsoft/terminal#12398. Using Terminal 1.13.10333.0

When updating to Controlsv2, the contrast between the active TabViewItem and the TabView background is basically indistinguishable. Qualitatively, the dark theme contrast seems more obvious in the Terminal, but the light theme difference is almost entirely unnoticable.

We don't have an a11y bug on us yet for this, but I suspect we will soon.

Steps to reproduce the bug

Add a TabView to an application

Expected behavior

Contrast between the tabs and the tabview background to be more distinct. Presumably we shouldn't need to style the tabs more to achieve a obvious distinction of which tab is active.

(I'm aware that the text on the focused tab is bolded, but that's an effect that's pretty subtle: image)

Screenshots

image
image

Controlsv1, for reference:
image

NuGet package version

Microsoft.UI.Xaml 2.7.0

Windows app type

  • Win32 & Xaml Islands

Device form factor

Desktop

Windows version

Insider Build (xxxxx), May 2021 Update (19043)

Additional context

No response

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 7, 2022
@StephenLPeters StephenLPeters added area-TabView area-UIDesign UI Design, styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 4, 2022
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@zadjii-msft
Copy link
Member Author

I maintain that this is still an issue. The default contrast ratio is just plain bad, and not everyone can easily adopt the pair of Mica experiences to increase contrast.

@duncanmacmichael duncanmacmichael added the bug Something isn't working label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TabView area-UIDesign UI Design, styling bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

3 participants