Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation panel is visible and placed on top if settings editor opened when terminal window is really narrow #13428

Closed
Tracked by #12400
serd2011 opened this issue Jul 4, 2022 · 4 comments
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@serd2011
Copy link
Contributor

serd2011 commented Jul 4, 2022

Windows Terminal version

1.13.11431.0

Windows build number

10.0.19043.1706]

Other Software

No response

Steps to reproduce

  1. Resize terminal window to have small width (then navigation panel is not visible at all and only 3-lines button is present)
  2. Open settings editor

This present in terminal 1.13.11431.0 from store, terminal preview 1.14.1451.0 from store, and in compiled 478c2c3

Expected Behavior

navigation panel is not shown and only button is present

Actual Behavior

navigation panel is visible and placed on top of the settings

Command.Prompt.2022-07-06.19-00-47.mp4

It fixes itself if 3-lines button is pressed. It then opens navigation panel with animation, displays is properly and after closing everything works as expected.
Or if terminal window is resized beyond the point when navigation panel is permanently shown as a narrow bar.

@serd2011 serd2011 added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 4, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 4, 2022
@zadjii-msft
Copy link
Member

Huh, that's sus, we saw this before in #9337. Maybe after the rejuv, we forgot to give it a fallback color (again)

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Settings UI Anything specific to the SUI labels Jul 6, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 6, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Jul 6, 2022
@serd2011
Copy link
Contributor Author

serd2011 commented Jul 6, 2022

I think it shouldn't be visible at all at this point. This happens after SUI is oppened and nav panel should not be shown.

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 7, 2022
@zadjii-msft
Copy link
Member

Y'know what, I can only repro this in a Windows 10 VM. I'd bet that this is just something fixed in Windows 11/?

I can't get the nav view to open expanded, in a small window, anywhere else. This is on a variety of 1.16 builds. I'm gonna let the bot close this one out in a week, unless someone's got a win11 repro.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 4, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.16, Backlog Aug 4, 2022
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Aug 8, 2022
@ghost
Copy link

ghost commented Aug 8, 2022

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants