Add Logical Network Support #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
ca73cfa
to
fc470c1
Compare
mjethwa-msft
requested review from
in3xes,
nijosmsft,
madhanrm and
JocelynBerrendonner
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
fef4698
to
957024d
Compare
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
957024d
to
3c392a0
Compare
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
3c392a0
to
aa524ff
Compare
nijosmsft
reviewed
Sep 25, 2023
| // AddressSpace - The AddressSpace that contains an array of IP address ranges that can be used by subnets. | ||
| AddressSpace *AddressSpace `json:"addressSpace,omitempty"` | ||
| // DhcpOptions - The dhcpOptions that contains an array of DNS servers available to VMs deployed in the Logical network. | ||
| DhcpOptions *DhcpOptions `json:"dhcpOptions,omitempty"` |
There was a problem hiding this comment.
why do we have dhcp options here?
There was a problem hiding this comment.
For LNET in SDN it is per subnet so I moved the dnsservers per subnet for LNET.
nijosmsft
reviewed
Sep 25, 2023
| wssdsubnet.Dns = &wssdcommonproto.Dns{ | ||
| Servers: *subnet.DhcpOptions.DNSServers, | ||
| } | ||
| } |
There was a problem hiding this comment.
why did we decide to use dhcp options for moc-sdk but just dnsservers for cloudagent?
There was a problem hiding this comment.
to keep the contract similar to virtual network.
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
1408d8e
to
caf8f45
Compare
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
caf8f45
to
4709705
Compare
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
4709705
to
94c0c57
Compare
mjethwa-msft
requested review from
raghavendra-nataraj
and removed request for
in3xes
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
94c0c57
to
ac72c73
Compare
msftpgayam
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design Spec: Link
Sample Test Commands: Added to the spec