-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple issues in current PR by crating V2 APIs #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…or-go into user/dama/fixwrapper
5691d0f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The current APIs have two major issues:
one improvement made to encrypt and decrypt API is made the algorithm as a parameter
Test:
I have modifies testMoc.exe in IgvmAgent (please see my draft code in branch user/dama/testwrapperfix in Igvmagent repo for reference).
Here are the test I have done:
SecurityLoginV2: tested happy path; wrong/empty login file path; invalid/empty group name
CrateKeyV2: tested happy path to create both AES and RSA key; invalid/empty group name
KeyvaultKeyDecryptDataV2: tested happy path; buffer too small case (caller call API twice to get decrypt working); invalid algorithm; invalid groupName/keyvaultName; empty input data
KeyvaultKeyEncryptDataV2: same test coverage as decrypt.Also tested Encrypt and decrypt together and made sure decrypted data matches original plaintext
KeyvaultKeyCreateOrUpdateV2: tested happy path to create AES key and RSA key; tested invalid algorithm;invalid/empty groupName/keyvaultName
KeyvaultGetPublicKeyV2: tested happy path; tested return key empty; invalid/empty groupName/keyvaultName/keyName
Tested the onefuzz repro, with the fix, original error went away.
Tested with replacing igvmagent in a haas cluster. TVM is stopping and starting with no issue.