Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several bug fixes #268

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

mduppre
Copy link

@mduppre mduppre commented Sep 22, 2024

These related PRs fix several issues:

  • Creating placeholders during the OS disk hydration failed (see https://msazure.visualstudio.com/One/_workitems/edit/29443919)
    • This happened as we are calling into the create code for the disk placeholders. That code constructs the filename from the name (which in a OS disk hydration is "my_disk-OsDisk", which is not the filename). So, we pass through the path to the create code and make sure to use that if it's given and construct the filename from the name otherwise
  • Creating the VM placeholders during a VM hydration failed
    • The VM placeholders, like the disk placeholders, use the create flow. However, we set the bootstrap engine to cloudinit during the hydration for VMs, which caused the create flow to try to create a seed.iso and related files as it didn't find those files already. When hydrating a VM, it's by definition already running and bootstrapped, so we should denote this in the store representation. We have added a new state "hydrated" to the bootstrap engine field so that we skip any validation or actual bootstrapping during the create flow for the placeholders.
  • In moccli, we were constructing the decorated name as <vm name>_subscription-id_resource-group. However, if we are using a Linux VM, we have some validation that Linux hostnames are not allowed to have underscores. So this default name got changed to <vm name>-subscription-id-resource-group

@mduppre mduppre merged commit 1809ecf into users/trailblazer/VmHydration Sep 27, 2024
1 check passed
@mduppre mduppre deleted the users/mduppre/bug_fix branch September 27, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant