Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command and additionalTextEdits to CompeltionItem. #642

Closed
akosyakov opened this issue Nov 24, 2017 · 4 comments
Closed

Add command and additionalTextEdits to CompeltionItem. #642

akosyakov opened this issue Nov 24, 2017 · 4 comments

Comments

@akosyakov
Copy link

It is required for the LSP: TypeFox/monaco-languageclient#39.

It looks like the conversion should be done here:
https://github.com/Microsoft/vscode/blob/63efefc7c279e7c963d223123d7248137034252a/src/vs/editor/standalone/browser/standaloneLanguages.ts#L626

@alexandrudima is there a reason not doing it?

@alexdima
Copy link
Member

@akosyakov The Monaco Editor API CompletionItemProvider tries to keep on par with the vscode API one. If they fall out of sync, it is only because somebody changed the vscode one, but forgot to change the Monaco Editor one.

@akosyakov
Copy link
Author

Would it be possible to sync them and publish a new patch version of monaco-editor?

@alexdima
Copy link
Member

PR welcome.

@akosyakov
Copy link
Author

@alexandrudima ok, i am looking into it

alexdima added a commit to microsoft/vscode that referenced this issue Jan 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants