Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic Tokens Provider Sample is broken in docs #2764

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Semantic Tokens Provider Sample is broken in docs #2764

merged 1 commit into from
Nov 12, 2021

Conversation

Pranomvignesh
Copy link
Contributor

Semantic Tokens Provider Sample is broken in docs

Video related to the issue

Screen.Recording.2021-11-12.at.9.03.29.AM.mov

Description

  • Issue occurred due to the missing colors key in the defineTheme API's ThemeDataObject
  • The colors key seems to be required as it is not mentioned as optional in the Interface IStandaloneThemeData
  • Adding colors key in the ThemeDataObject fixes the issue

@alexdima
Copy link
Member

Thank you!

@alexdima alexdima added this to the November 2021 milestone Nov 12, 2021
@alexdima alexdima merged commit 734e1cb into microsoft:main Nov 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
November 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranomvignesh @alexdima