Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Webpack Plugin] Fix CJS being injected in ESM files #3933

Merged
merged 1 commit into from
May 2, 2023
Merged

[Webpack Plugin] Fix CJS being injected in ESM files #3933

merged 1 commit into from
May 2, 2023

Conversation

titouanmathis
Copy link
Contributor

I replaced the CJS require and module.exports with import and export statements.

This PR should fix #2735.

Tests are ok on my dev environment.

@hediet hediet enabled auto-merge May 2, 2023 12:37
@hediet hediet added this to the May 2023 milestone May 2, 2023
@hediet hediet merged commit 358be7c into microsoft:main May 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hediet hediet hediet approved these changes

@aeschli aeschli aeschli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

monaco-editor/esm/vs/editor/editor.api is transformed into cjs instead of esm any more
3 participants
@titouanmathis @hediet @aeschli