Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Properly tokenize fence closing in GitHub style code blocks #149

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Properly tokenize fence closing in GitHub style code blocks #149

merged 1 commit into from
Jul 22, 2021

Conversation

jonatanklosko
Copy link
Contributor

Currently Markdown tokenizer marks both opening and closing ``` as string. However, if the opening one includes language as in ```elixir, then the closing one is incorrectly tokenized as variable.source.

@hediet
Copy link
Member

hediet commented Jul 22, 2021

Thank you for you PR!

Why is variable.source wrong though?

@jonatanklosko
Copy link
Contributor Author

Currently the closing fence is tokenized differently if there's a langauge, for example:

image

Except this specific case it's tokenized as string.

@hediet hediet added this to the July 2021 milestone Jul 22, 2021
@hediet
Copy link
Member

hediet commented Jul 22, 2021

Makes sense, thanks!

@hediet hediet merged commit 52597f7 into microsoft:main Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants