Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also exclude for Behat #34

Closed
wants to merge 1 commit into from

Conversation

aspark21
Copy link

@aspark21 aspark21 commented Jul 5, 2022

Fixes the very noisy Behat failures (60+) like this one

And I press "Save changes": debugging() message/s found:
SKIPPED: handle_notification_sent - incomplete settings
line 915 of /local/o365/classes/observers.php: call to debugging()
line ? of unknownfile: call to local_o365\observers::handle_notification_sent()
line 155 of /lib/classes/event/manager.php: call to call_user_func()
line 75 of /lib/classes/event/manager.php: call to core\event\manager::process_buffers()
line 834 of /lib/classes/event/base.php: call to core\event\manager::dispatch()
line 459 of /lib/classes/message/manager.php: call to core\event\base->trigger()
line 340 of /lib/classes/message/manager.php: call to core\message\manager::trigger_message_events()
line 346 of /lib/messagelib.php: call to core\message\manager::send_message()
line 6457 of /mod/assign/locallib.php: call to message_send()
line 6485 of /mod/assign/locallib.php: call to assign::send_assignment_notification()
line 6544 of /mod/assign/locallib.php: call to assign->send_notification()
line 7539 of /mod/assign/locallib.php: call to assign->notify_student_submission_receipt()
line 7576 of /mod/assign/locallib.php: call to assign->save_submission()
line 493 of /mod/assign/locallib.php: call to assign->process_save_submission()
line 55 of /mod/assign/view.php: call to assign->view()
 (Exception)

@weilai-irl
Copy link
Collaborator

Hi @aspark21,

Thank you for making the PR. I have included the changes in the main project in microsoft/o365-moodle#2132 and microsoft/o365-moodle#2133, and they will be included in the next release.

Regards,
Lai

@weilai-irl
Copy link
Collaborator

Hi @aspark21

Thank you again for making the PR. The changes have been merged into the main project, and has been included in the release from today.

I'm going to close this PR now.

Regards,
Lai

@weilai-irl weilai-irl closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants