Validate the input value of -pid. (#2061)

Make sure that the pid exists before running the `perf` command. Co-authored-by: Brian Robbins <brianrob@linux.microsoft.com>
microsoft · Jul 15, 2024 · f68d871 · f68d871
1 parent 810102e
commit f68d871
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/perfcollect/perfcollect b/src/perfcollect/perfcollect
@@ -2025,7 +2025,13 @@ BuildPerfRecordArgs()
     # Filter to a single process if desired
     if [ "$collectionPid" != "" ]
     then
-        collectionArgs="$collectionArgs --pid=$collectionPid"
+        if ps -p "$collectionPid" > /dev/null;
+        then
+            collectionArgs="$collectionArgs --pid=$collectionPid"
+        else
+            WriteWarning "Process with PID '$collectionPid' does not exist.  Please specify a valid PID."
+            exit 1
+        fi
     else
         collectionArgs="$collectionArgs -a"
     fi