Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TraceEvent] Extend RuntimeSku to recognize Mono #1658

Merged
merged 1 commit into from
Jul 6, 2022
Merged

[TraceEvent] Extend RuntimeSku to recognize Mono #1658

merged 1 commit into from
Jul 6, 2022

Conversation

mdh1418
Copy link
Contributor

@mdh1418 mdh1418 commented Jul 5, 2022

In dotnet/runtime, dotnet/runtime#71657 and dotnet/runtime#71359 extend RuntimeSku in EventTrace to recognize Mono runtime as 0x4. Adding the same extension here so that the value shows up as Mono instead of 4.

@mdh1418
Copy link
Contributor Author

mdh1418 commented Jul 5, 2022

/cc: @brianrob

brianrob
brianrob approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@brianrob brianrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once the runtime change is merged, let me know and I'll merge this.

@mdh1418
Copy link
Contributor Author

mdh1418 commented Jul 6, 2022

@brianrob dotnet/runtime#71657 is now merged!

@brianrob brianrob merged commit ab8c29e into microsoft:main Jul 6, 2022
@mdh1418 mdh1418 deleted the extend_traceevent_parser_with_runtimesku_mono branch July 6, 2022 23:41
This was referenced Jul 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianrob brianrob brianrob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdh1418 @brianrob