feat: support artifact collection with multiple contexts #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
support-multiple-contexts
branch
2 times, most recently
from
3c5772a
to
caf2c38
Compare
mxschmitt
changed the title
mxschmitt
changed the title
mxschmitt
force-pushed
the
support-multiple-contexts
branch
from
8905f0a
to
c0db2a6
Compare
dgozman
reviewed
Apr 16, 2024
| os.makedirs(os.path.dirname(trace_path), exist_ok=True) | ||
| shutil.move(trace, trace_path) | ||
| else: | ||
| os.remove(trace) |
There was a problem hiding this comment.
We should also remove when !failed and self._tracing_option == "retain-on-failure"
mxschmitt
force-pushed
the
support-multiple-contexts
branch
from
a780f91
to
9e81611
Compare
dgozman
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch manually created contexts were not taken into consideration for tracing, video, and screenshot generation. After this patch tracing and video is fully supported. Screenshots get only taken for pages which are still open, this was already the case before.
The signature of
new_contextneeds to be manually getting mirrored, I found no way of doing this like we can in e.g. TypeScript.Unrelated: Supporting retries might be something we can support in the future, but this is not in scope of this PR.
Fixes #209
Fixes #111
Fixes #99