fix: add new line before sourceURL (#29199)

Reference #29116
microsoft · Jan 29, 2024 · 13550b7 · 13550b7
1 parent ad6e405
commit 13550b7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/playwright-core/src/client/clientHelper.ts b/packages/playwright-core/src/client/clientHelper.ts
@@ -43,8 +43,12 @@ export async function evaluationScript(fun: Function | string | { path?: string,
   if (fun.path !== undefined) {
     let source = await fs.promises.readFile(fun.path, 'utf8');
     if (addSourceUrl)
-      source += '\n//# sourceURL=' + fun.path.replace(/\n/g, '');
+      source = addSourceUrlToScript(source, fun.path);
     return source;
   }
   throw new Error('Either path or content property must be present');
 }
+
+export function addSourceUrlToScript(source: string, path: string): string {
+  return `${source}\n//# sourceURL=${path.replace(/\n/g, '')}`;
+}
diff --git a/packages/playwright-core/src/client/frame.ts b/packages/playwright-core/src/client/frame.ts
@@ -35,6 +35,7 @@ import { kLifecycleEvents } from './types';
 import { urlMatches } from '../utils/network';
 import type * as api from '../../types/types';
 import type * as structs from '../../types/structs';
+import { addSourceUrlToScript } from './clientHelper';
 
 export type WaitForNavigationOptions = {
   timeout?: number,
@@ -266,7 +267,7 @@ export class Frame extends ChannelOwner<channels.FrameChannel> implements api.Fr
     const copy = { ...options };
     if (copy.path) {
       copy.content = (await fs.promises.readFile(copy.path)).toString();
-      copy.content += '//# sourceURL=' + copy.path.replace(/\n/g, '');
+      copy.content = addSourceUrlToScript(copy.content, copy.path);
     }
     return ElementHandle.from((await this._channel.addScriptTag({ ...copy })).element);
   }