Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: --only-changed flag and project dependencies #32070

Closed
andreicherechesbyx opened this issue Aug 8, 2024 · 3 comments · Fixed by #32094
Closed

[Bug]: --only-changed flag and project dependencies #32070

andreicherechesbyx opened this issue Aug 8, 2024 · 3 comments · Fixed by #32094
Assignees
@Skn0tt
Labels
v1.47

Comments

@andreicherechesbyx
Copy link

Version

1.46.0

Steps to reproduce

  1. Create a repo with multiple projects
  2. Add dependencies to the project
  3. Modify some of the test files
  4. Run test with --only-changed flag

Expected behavior

The dependencies are run before the actual modified tests.

Actual behavior

Only the modified test are run, which fail without the dependencies.

Additional context

I have multiple projects with a login setup as dependency

Environment

System:
    OS: macOS 14.5
    CPU: (8) x64 Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz
    Memory: 15.41 MB / 16.00 GB
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
  Languages:
    Bash: 3.2.57 - /bin/bash
  npmPackages:
    @playwright/test: ^1.40.1 => 1.46.0
@yury-s yury-s added the v1.47 label Aug 8, 2024
@Skn0tt
Copy link
Member

Skn0tt commented Aug 9, 2024

Hi Andrei! Thanks for reporting the issue. I'm having trouble reproducing this on my end. Could you provide me with a reproduction repository, as the issue form requested?

@Skn0tt Skn0tt mentioned this issue Aug 9, 2024
Merged
@andreicherechesbyx
Copy link
Author

Repo: https://github.com/boatyardx/playwright-crossbrowser/tree/only-changed

I added a console.log() statement:

image

While the change to console.log() was detected, the setup dependency was not updated:

image

Also, is it intended for the entire test file to run instead of only the modified test?

@Skn0tt
Copy link
Member

Skn0tt commented Aug 12, 2024

Thanks, that helps reproducing! I'll look into writing a fix.

Also, is it intended for the entire test file to run instead of only the modified test?

Yes, that's intended.

Skn0tt added a commit that referenced this issue Aug 12, 2024
@Skn0tt
fix(test runner): run project dependencies of --only-changed test f…
edd1894 
…iles (#32094)

Closes #32070. We were
applying `additionalFileMatcher` not just to `filteredProjectSuites`,
but also to `projectSuites`. `projectSuites` is where we take dependency
projects from, though - so `--only-changed` led to empty dependency
projects, resulting in the reported bug.

The fix is to only apply `additionalFileMatcher` on
`filteredProjectSuites`.
@pavelfeldman pavelfeldman mentioned this issue Aug 13, 2024
Closed
Skn0tt added a commit to Skn0tt/playwright that referenced this issue Aug 15, 2024
@Skn0tt
fix(test runner): run project dependencies of --only-changed test f…
20cea20 
…iles (microsoft#32094)

Closes microsoft#32070. We were
applying `additionalFileMatcher` not just to `filteredProjectSuites`,
but also to `projectSuites`. `projectSuites` is where we take dependency
projects from, though - so `--only-changed` led to empty dependency
projects, resulting in the reported bug.

The fix is to only apply `additionalFileMatcher` on
`filteredProjectSuites`.
@Skn0tt Skn0tt mentioned this issue Aug 15, 2024
Merged
Skn0tt added a commit that referenced this issue Aug 15, 2024
@Skn0tt
cherry-pick(#32094): fix(test runner): run project dependencies of `-…
7cf7aec 
…-only-changed` test files (#32172)

Closes #32070. We were
applying `additionalFileMatcher` not just to `filteredProjectSuites`,
but also to `projectSuites`. `projectSuites` is where we take dependency
projects from, though - so `--only-changed` led to empty dependency
projects, resulting in the reported bug.
    
The fix is to only apply `additionalFileMatcher` on
`filteredProjectSuites`.
@gvdenbro gvdenbro mentioned this issue Aug 19, 2024
Merged
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this issue Sep 1, 2024
@cq-bot
fix(deps): Update dependency @playwright/test to v1.46.1 (#19052)
5b8accf 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@playwright/test](https://playwright.dev) ([source](https://github.com/microsoft/playwright)) | devDependencies | patch | [`1.46.0` -> `1.46.1`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.46.0/1.46.1) |
| [@playwright/test](https://playwright.dev) ([source](https://github.com/microsoft/playwright)) | devDependencies | minor | [`1.45.3` -> `1.46.1`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.45.3/1.46.1) |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>microsoft/playwright (@&#8203;playwright/test)</summary>

### [`v1.46.1`](https://github.com/microsoft/playwright/releases/tag/v1.46.1)

[Compare Source](https://github.com/microsoft/playwright/compare/v1.46.0...v1.46.1)

##### Highlights

[microsoft/playwright#32004 - \[REGRESSION]: Client Certificates don't work with Microsoft IIS[microsoft/playwright#32004 - \[REGRESSION]: Websites stall on TLS handshake errors when using Client Certificate[microsoft/playwright#32146 - \[BUG]: Credential scanners warn about internal socks-proxy TLS certificat[microsoft/playwright#32056 - \[REGRESSION]: 1.46.0 (TypeScript) - custom fixtures extend no longer chaina[microsoft/playwright#32070 - \[Bug]: --only-changed flag and project dependen[microsoft/playwright#32188 - \[Bug]: --only-changed with shallow clone throws "unknown revision" error

##### Browser Versions

-   Chromium 128.0.6613.18
-   Mozilla Firefox 128.0
-   WebKit 18.0

This version was also tested against the following stable channels:

-   Google Chrome 127
-   Microsoft Edge 127

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
This was referenced Sep 7, 2024
Open
Open
@ARUMAIS ARUMAIS mentioned this issue Sep 7, 2024
Open
This was referenced Sep 7, 2024
Open
Open
@ARUMAIS ARUMAIS mentioned this issue Sep 8, 2024
Open
@leonardoadame leonardoadame mentioned this issue Sep 9, 2024
Open
@ARUMAIS ARUMAIS mentioned this issue Sep 9, 2024
Open
@WontonSam WontonSam mentioned this issue Sep 9, 2024
Open
@leonardoadame leonardoadame mentioned this issue Sep 10, 2024
Open
This was referenced Sep 10, 2024
Open
Open
@leonardoadame leonardoadame mentioned this issue Sep 11, 2024
Open
@black-da-bull black-da-bull mentioned this issue Sep 12, 2024
Open
@ARUMAIS ARUMAIS mentioned this issue Sep 12, 2024
Open
@WontonSam WontonSam mentioned this issue Sep 12, 2024
Open
@leonardoadame leonardoadame mentioned this issue Sep 12, 2024
Open
@ARUMAIS ARUMAIS mentioned this issue Sep 13, 2024
Open
@AlbertChambers AlbertChambers mentioned this issue Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Open
This was referenced Sep 14, 2024
Open
Open
Open
@AlbertChambers AlbertChambers mentioned this issue Sep 16, 2024
Open
@leonardoadame leonardoadame mentioned this issue Sep 16, 2024
Open
@AlbertChambers AlbertChambers mentioned this issue Sep 17, 2024
Open
This was referenced Sep 17, 2024
Open
Open
This was referenced Sep 19, 2024
Open
Open
This was referenced Sep 19, 2024
Open
Open
@AlbertChambers AlbertChambers mentioned this issue Sep 20, 2024
Open
This was referenced Sep 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skn0tt Skn0tt

Labels
v1.47
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test runner): run project dependencies of --only-changed test files Skn0tt/playwright
3 participants
@yury-s @Skn0tt @andreicherechesbyx