fix(tracing): bump trace version to V5, migrate V4 traces to consoleMessage.args #27162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Sep 18, 2023
dgozman
changed the title
dgozman
force-pushed
the
trace-fix-console-new-version
branch
from
7755422
to
ad8e6dc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Sep 19, 2023
dgozman
force-pushed
the
trace-fix-console-new-version
branch
from
e869cf3
to
815b18a
Compare
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
trace-fix-console-new-version
branch
from
815b18a
to
30b7181
Compare
Test results for "tests 1"8 flaky25663 passed, 604 skipped Merge workflow run. |
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Sep 19, 2023
… migrate V4 traces to consoleMessage.args This moves the fix in microsoft#27095 from `modernize` to `appendEvent`. The reason is that `trace V4` is used both for older traces that do not have `consoleMessage.args` and the new ones with `args`. Since we do not call `modernize` for traces of the same version, the original fix does not help in this case. Fixes microsoft#27144.
dgozman
added a commit
that referenced
this pull request
Sep 20, 2023
…V4 traces to consoleMessage.args (#27193) This moves the fix in #27095 from `modernize` to `appendEvent`. The reason is that `trace V4` is used both for older traces that do not have `consoleMessage.args` and the new ones with `args`. Since we do not call `modernize` for traces of the same version, the original fix does not help in this case. Fixes #27144.
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
…essage.args (microsoft#27162) This moves the fix in microsoft#27095 from `modernize` to `appendEvent`. The reason is that `trace V4` is used both for older traces that do not have `consoleMessage.args` and the new ones with `args`. Since we do not call `modernize` for traces of the same version, the original fix does not help in this case. Fixes microsoft#27144.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the fix in #27095 from
modernizetoappendEvent. The reason is thattrace V4is used both for older traces that do not haveconsoleMessage.argsand the new ones withargs. Since we do not callmodernizefor traces of the same version, the original fix does not help in this case.Fixes #27144.