-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vrt): allow providing screenshot style #28229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
hide_remove
branch
from
November 18, 2023 02:30
800d2c7
to
d19f61a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Nov 18, 2023
pavelfeldman
force-pushed
the
hide_remove
branch
from
November 18, 2023 23:08
d19f61a
to
996d703
Compare
dgozman
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
hide_remove
branch
from
November 28, 2023 00:37
996d703
to
35cfb40
Compare
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
hide_remove
branch
from
November 30, 2023 22:36
35cfb40
to
c06f626
Compare
pavelfeldman
changed the title
feat(vrt): allow hiding and remove elements from screenshots
feat(vrt): allow providing screenshot style
Nov 30, 2023
dgozman
approved these changes
Nov 30, 2023
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
hide_remove
branch
from
November 30, 2023 23:10
c06f626
to
0206cf3
Compare
Test results for "tests 1"4 flaky26203 passed, 612 skipped Merge workflow run. |
This was referenced Dec 16, 2023
YusukeIwaki
added a commit
to YusukeIwaki/playwright-ruby-client
that referenced
this pull request
Dec 24, 2023
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.