Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vrt): allow providing screenshot style #28229

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

pavelfeldman
Copy link
Member

No description provided.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This

packages/playwright-core/src/server/screenshotter.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/server/screenshotter.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/server/screenshotter.ts Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

@pavelfeldman pavelfeldman changed the title feat(vrt): allow hiding and remove elements from screenshots feat(vrt): allow providing screenshot style Nov 30, 2023

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live

26203 passed, 612 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants