chore: remove manual __esModule override

[pavelfeldman]

No description provided.

[jdalton]

Related to #28875.

[jdalton]

Test results for "tests 1"

1 failed ❌ [playwright-test] › basic.spec.ts:240:5 › should work with default export

playwright/tests/playwright-test/basic.spec.ts

Lines 240 to 252 in 19a4f15

	test('should work with default export', async ({ runInlineTest }) => {
	const result = await runInlineTest({
	'file.spec.ts': `
	import t from '@playwright/test';
	t('passed', () => {
	t.expect(1 + 1).toBe(2);
	});
	`
	});
	expect(result.exitCode).toBe(0);
	expect(result.passed).toBe(1);
	expect(result.failed).toBe(0);
	});

The test is failing because:

import t from '@playwright/test'

is expecting t.test to exist but that is not how it's exported. See

playwright/packages/playwright/test.mjs

Line 33 in 19a4f15

export default playwright.test;

The playwright.test does not have test as a property (so no playwright.test.test) thought it does have playwrightFixtures:

playwright/packages/playwright/src/index.ts

Line 746 in 19a4f15

export const test = _baseTest.extend<TestFixtures, WorkerFixtures>(playwrightFixtures);

This can be addressed if you wish by doing:

combinedExports.test = Object.assign(combinedExports.test, combinedExports);

In packages/playwright/test.js
OR

export default playwright;

in packages/playwright/test.mjs

OR both 😺

[pavelfeldman]

Sounds good, I'll try with

module.exports = Object.assign(combinedExports.test, combinedExports);

[github-actions]

Test results for "tests 1"

3 flaky

⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

14852 passed, 310 skipped
✔️✔️✔️

Merge workflow run.