-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(electron): stalling on delayed process close #29431
Merged
mxschmitt
merged 6 commits into
microsoft:main
from
mxschmitt:fix/electron-slower-close
Feb 13, 2024
Merged
fix(electron): stalling on delayed process close #29431
mxschmitt
merged 6 commits into
microsoft:main
from
mxschmitt:fix/electron-slower-close
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
fix/electron-slower-close
branch
from
February 12, 2024 09:48
96dac65
to
bf2d0b5
Compare
mxschmitt
force-pushed
the
fix/electron-slower-close
branch
from
February 12, 2024 09:49
bf2d0b5
to
6ca5588
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Feb 12, 2024
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Feb 12, 2024
dgozman
approved these changes
Feb 12, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"7 flaky26581 passed, 611 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigation notes:
When we call
ElectronApplication.close()
, we return before the actual process has been exited. This can/will lead under certain timing conditions to thatgracefullyCloseSet
still has an entry.When the worker then tries to exit, we call these entries, which will do
options.attemptToGracefullyClose()
. A recursive call toElectronApplication.close()
which will never resolve, due to the fact that we callBrowserContext.close
again (good) but the actualclose
event will only be fired once. See here. This is why it was stalling for 30s.Changes:
Based on that, I see 2 changes which we should do:
Browser.close()
->gracefullyClose
).Fixes #27523